Open
Conversation
Replace vulnerable `url-regex` with `url-regex-safe`
Cj-bc
added a commit
to Cj-bc/gulp-concat-css
that referenced
this pull request
Nov 15, 2020
Current version of rework-import is depends on 'url-regex', which have high severity vulnerability, and it's recommended to use 'url-regex-safe' instead: CVE: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-7661 There're PR for rework-import, which is dependency of this and depends on 'url-regex', to use 'url-regex-safe': reworkcss/rework-import#20 But it's not merged yet (Actually I don't believe it will be merged in the future) so that I directly use his branch to fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace vulnerable
url-regexwithurl-regex-safe.This would have the unfortunate side-effect of requiring node 10.12.0 or later.