Skip to content

chore: sanitize spam example references #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rezhajulio wants to merge 1 commit into from
+10 −10
Closed

chore: sanitize spam example references #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/bot/handlers/bio_bait.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@

1. Bait phrase in the message text (e.g. "cek bio aku", "liat byoh").
2. The user's *Telegram profile bio* itself contains promo/scam links
(e.g. "VIP BCL t.me/+KVUG7Nzphek0N2M1"). In this case the group message
may be innocuous; the spam is in the bio. We fetch the bio once per
hour per user and cache it.
(private t.me/+ invite links and/or non-whitelisted @mentions). In
this case the group message may be innocuous; the spam is in the bio.
We fetch the bio once per hour per user and cache it.

On match the handler deletes the message, restricts the user, and posts a
notification to the warning topic.
Expand Down Expand Up @@ -99,7 +99,7 @@
),
)

# Telegram private invite links (e.g. t.me/+KVUG7Nzphek0N2M1).
# Telegram private invite links (t.me/+<hash>).
TELEGRAM_INVITE_LINK_RE = re.compile(
r"(?:https?://)?(?:t\.me|telegram\.me)/\+[A-Za-z0-9_-]{8,}",
re.IGNORECASE,
Expand Down
12 changes: 6 additions & 6 deletions tests/test_bio_bait.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,11 @@ def test_empty_bio(self):
assert has_suspicious_bio_links("") is False

def test_invite_link(self):
bio = "VIP BCL t.me/+KVUG7Nzphek0N2M1 ASP"
bio = "VIP promo t.me/+exampleinvitehash ASP"
assert has_suspicious_bio_links(bio) is True

def test_invite_link_with_https(self):
assert has_suspicious_bio_links("https://t.me/+abcdefghij") is True
assert has_suspicious_bio_links("https://t.me/+exampleinvitehash") is True

def test_non_whitelisted_public_link(self):
assert has_suspicious_bio_links("Join t.me/somerandomscamchannel") is True
Expand Down Expand Up @@ -325,7 +325,7 @@ async def test_detects_via_bio_links_with_innocuous_message(
):
mock_update.message.text = "halo"
chat = MagicMock()
chat.bio = "VIP BCL t.me/+KVUG7Nzphek0N2M1"
chat.bio = "VIP promo t.me/+exampleinvitehash"
mock_context.bot.get_chat = AsyncMock(return_value=chat)

with patch("bot.handlers.bio_bait.get_group_config_for_update", return_value=group_config):
Expand All @@ -352,7 +352,7 @@ async def test_no_text_with_bad_bio_triggers_restriction(
mock_update.message.text = None
mock_update.message.caption = None
chat = MagicMock()
chat.bio = "VIP t.me/+abcdefghij"
chat.bio = "VIP t.me/+exampleinvitehash"
mock_context.bot.get_chat = AsyncMock(return_value=chat)

with patch("bot.handlers.bio_bait.get_group_config_for_update", return_value=group_config):
Expand All @@ -365,7 +365,7 @@ async def test_restriction_clears_bio_cache(
):
mock_update.message.text = "halo"
chat = MagicMock()
chat.bio = "VIP t.me/+abcdefghij"
chat.bio = "VIP t.me/+exampleinvitehash"
mock_context.bot.get_chat = AsyncMock(return_value=chat)

with patch("bot.handlers.bio_bait.get_group_config_for_update", return_value=group_config):
Expand Down Expand Up @@ -399,7 +399,7 @@ async def test_restrict_failure_for_bio_link_uses_no_restrict_template(
):
mock_update.message.text = "halo"
chat = MagicMock()
chat.bio = "VIP t.me/+abcdefghij"
chat.bio = "VIP t.me/+exampleinvitehash"
mock_context.bot.get_chat = AsyncMock(return_value=chat)
mock_context.bot.restrict_chat_member = AsyncMock(side_effect=Exception("fail"))

Expand Down