Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new VBreadcrumb component along with supporting utilities for handling breadcrumb navigation in a Vue/Nuxt application. The component integrates with Roadiz CMS and provides structured data support for SEO.
- Adds a reusable VBreadcrumb component with styling and accessibility features
- Creates a composable for extracting breadcrumb data from Roadiz web responses
- Implements JSON-LD structured data generation for breadcrumbs
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/utils/json-ld.ts | Utility functions for cleaning and generating JSON-LD structured data |
| app/composables/use-roadiz-breadcrumb.ts | Composable for extracting breadcrumb items from Roadiz web responses |
| app/components/organisms/VBreadcrumb/VBreadcrumb.vue | Main breadcrumb component with structured data and accessibility features |
| app/components/organisms/VBreadcrumb/*.stories.vue | Storybook examples demonstrating different breadcrumb scenarios |
| app/assets/stories/fixtures/web-responses/sub-page.json | Test fixture data for breadcrumb stories |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| }) | ||
|
|
||
| const breadcrumbItems = computed(() => { |
There was a problem hiding this comment.
the API seems weird to me. IMO the composable should only return items, and optionaly use home and current item. Without looking at the code, I cannot understand the difference between breadcrumbItems and allItems.
Maybe it could be have options to the composable like { useHome?: boolean, useCurrentPage?: boolean}
No description provided.