Add improved silkscreen, DigiKey BOM, Linux build script and update README#3
Add improved silkscreen, DigiKey BOM, Linux build script and update README#3danboid wants to merge 33 commits intorfmerrill:mainfrom
Conversation
|
I said I was going to test this before making a PR but I've not changed anything apart from the silkscreen, adding mount holes and rounding the corners of the board so if it worked for you then it should still work, I hope. I may make another PR after building it if I think of any good tips to add or we might add a photo of a finished board to the README or whatever? 16 commits, 16 bits |
Mega-Drive-DB9-pinout.jpg
Outdated
There was a problem hiding this comment.
There's no such thing as a "DB-9". The connectors used here are similar to DE-9, but not quite the same. While an Atari/Sega/etc joystick connector will usually mate with a DE-9, they are different enough that it's not recommended (the joystick plug can be bent or damaged by the smaller opening of a DE-9 socket).
There was a problem hiding this comment.
Could you remove the extra copy of this file?
rfmerrill
left a comment
rfmerrill
left a comment
There was a problem hiding this comment.
Some of the things I'm concerned about. I'm not demanding you make these changes yourself, but I might want to make them before I merge it.
I haven't had a chance to get KiCAD installed again and open up the project files to look at it either. Sorry about that. I'll try to soon.
Mega-Drive-DB9-pinout.jpg
Outdated
There was a problem hiding this comment.
Could you remove the extra copy of this file?
Mega-Drive-connector-pinout.jpg
Outdated
There was a problem hiding this comment.
I kind of want to move all of these images into a subdirectory so they're not cluttering up the top level dir.
|
I have fixed all of the things Bob. Hopefully this is good to merge now? I've been githubbing hard for many years now but this has been my longest and hardest PR ever. I didn't see it coming. If you don't have KiCAD installed, you can check it out using the online KiCAD viewer using a Chrome-based browser: |
|
@danboid Hi sorry for taking a while to reply. Don't call me Bob, Bob is my dad's name :P Thank you for all the work! Also thanks for cluing me in about kicanvas that's really handy. I do think I want to eventually merge this PR but I am still anxious about doing it without testing everything myself and I don't know whether I'll have time for that. Maybe I'll get over it and just hit the merge button though xD |
2 participants
No description provided.