This repository was archived by the owner on Jan 11, 2022. It is now read-only.
Open
Conversation
By using requestAnimationFrame Safari runs much smoother.
SassNinja
force-pushed
the
perf/scrolling
branch
from
37e08aa to
15d6a28
Compare
To not break the resize listener that params must be piped through to every css() call
There too many css() calls to pass the boolean everywhere reliably (apart from not looking good). Though I'm simply toggling useAF on instance level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was facing major performance issues in Safari resulting in jumping on quick scrolling.
The more content I've had in my sticky container the worse it was.
This PR improves the scrolling performance by using requestAnimationFrame what fixes my the Safari issue.
I've taken over the code from #68 (hope you don't mind @Kukiwon) and polished it a bit.
Also fixes #43