Add commitment annex and adjust links to it #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
St333p
changed the title
nicbus
requested changes
Nov 27, 2025
annexes/commitments.md
Outdated
Comment on lines
185
to
192
| `OpCommitment` consists of a sub-commitments to blocks of the | ||
| operation data, where each sub-commitment is created with a custom procedure. | ||
| For instance, operation global state, inputs and assignments are merklized, | ||
| such that a succinct proofs of some specific state or input inclusion in RGB | ||
| operation can be produced and used in smart contracts. Additionally to that, | ||
| assignments are concealed before the merklization, and range proofs are | ||
| removed from the commitment, such that an aggregation of the historical proofs | ||
| can be applied without changing the operation ids. |
There was a problem hiding this comment.
this feels odd, can we rephrase it to make it easier to understand?
Co-authored-by: Nicola Busanello <nicola.busanello@gmail.com>
nicbus
requested changes
Dec 3, 2025
|
|
||
| ### `CommitId` trait | ||
|
|
||
| This trait is automatically implemented for all types thjat implement `CommitEncode` and |
There was a problem hiding this comment.
Suggested change
| This trait is automatically implemented for all types thjat implement `CommitEncode` and | |
| This trait is automatically implemented for all types that implement `CommitEncode` and |
| `Transition` types through a dedicated `OpCommitment` structure that is then | ||
| strict-serialized and hashed. | ||
|
|
||
| `OpCommitment` consists in a set of commitments to blocks of the operation data, each |
There was a problem hiding this comment.
Suggested change
| `OpCommitment` consists in a set of commitments to blocks of the operation data, each | |
| `OpCommitment` consists of a set of commitments to blocks of the operation data, each |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an annex that describes into more details how commitments are derived. It is a slight adaptation of the document at https://github.com/rgb-protocol/rgb-consensus/blob/0.11.1-rc.1/doc/Commitments.md. There already were many links to it throughout the docs, which were updated accordingly.
It also provides a glossary entry for Merkle Tree, which is referenced by the newly added annex.