Skip to content

fix: properly check for array #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brunozoric wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: properly check for array #25

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b447ad
fix: properly check for array
brunozoric Apr 9, 2021
06769c6
fix: add instanceof check before the prototype check
brunozoric Apr 9, 2021
e35a37b
feat: do some prechecks before array checking if is array
brunozoric Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,19 @@
var TOKEN_NULL = -3;
var TOKEN_EMPTY_STRING = -4;
var TOKEN_UNDEFINED = -5;

var isArray = Array.isArray;
if (typeof isArray !== "function") {
isArray = function(item) {
if (!item || typeof item !== "object") {
return false;
}
else if (item instanceof Array) {
return true;
}
return Object.prototype.toString.call(item) === '[object Array]';
}
}

var pack = function(json, options) {

Expand Down Expand Up @@ -61,7 +74,7 @@
}

// Case 1: The item is Array Object
if ( item instanceof Array) {
if (isArray(item)) {

// Create a new sub-AST of type Array (@)
var ast = ['@'];
Expand Down