Add support for multiple devices#89
Open
MRigal wants to merge 2 commits intorgerganov:masterfrom
Open
Conversation
Owner
|
Thanks for the patch, I can't test it right now, will let you know when I give it a try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request #68 has been rebased to support latest sensors and the #ifdef for OSX has been removed to add support for multiple devices for OSX too.
Note that I've noticed some bug in the implementation of @taladar as the key mapping has to be done in ascending order of
-k, elsewhise some assignement is overwritten.@rgerganov it reverts the preprocessor distinguishing the OSes in libhdi but it works well this way for me. Test it also maybe.
Please note that I'm not a C developer and I've just tried to make it work enough for me.