implement self-healing sync and deterministic hierarchy plan#46
Merged
implement self-healing sync and deterministic hierarchy plan#46
Conversation
This commit renames the newly added subcommands to be more intuitive, matching familiar git CLI patterns. `conf check-sync` becomes `conf status` and `conf repair-sync` becomes `conf clean`.
The testing package forbids calling t.Parallel() in tests that also use t.Setenv or t.Chdir. Since many of our command tests use these process-global mutations, we must serialize them using the package-level mutex without marking them as parallel. This prevents the 'panic: testing: test using t.Setenv or t.Chdir can not use t.Parallel' seen in CI.
…t and fixing unused parameters This commit fixes several linting issues in the new test files, including unused testing.T parameters and ensuring all process-global mutating tests correctly use the runParallelCommandTest lock.
This commit ensures all tests in the cmd package that use process-global state (like working directory or environment variables) correctly acquire the runParallelCommandTest lock, fixing potential flakiness and satisfying linting rules for unused testing.T.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.confluence-state.jsonconflict-marker corruption, including remote/local index rebuild and persisted recoveryX/X.md) over folders and collapsing folder parents when index pages are introducedspacefrontmatter as a sync requirement, add dirty-deletion pull warnings, and introducecheck-sync/repair-syncoperational commands (withstatus/cleanaliases)Validation
make testmake lint