Added browser and node local storage capabilities #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t found. Test has been fixed as well. Closed #2
…allow temporary files to be created
Member
Author
|
Ignore the failing builds right now... There appears to be an issue with Travis-CI Xenial image. I put in a comment at https://travis-ci.community/t/xenial-kernel-does-not-appear-to-have-sandbox-capabilities/5370. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a storage factory that returns local storage based on browser or node environment. The browser uses the built in
localStoragefunctionality of browsers. Node currently uses a module that provides the same interface.Webpack has been updated so when it runs, it will not package the node modules. This makes the tests better because it is using just the browser at that point.
The tests were rewritten so that anything that deals with file operations occurs on both platforms. Like rgpm/core.
I tried to test basic operations. The tests can be expanded for sure, but they are a good starting point.