add user defined functions to power-puter #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you'll accept LLM generated code. Even with an LLM doing the heavy lifting it wasn't straight-forward.
There is still one "bug": it retains that coffee flavored _return without using the
returnkeyword` that puter already had.Otherwise, it works inside the same node as where it is defined, or passed as an argument to another node.
*argsand**kwargswork correctly.FTR it's not that I thought you particulary needed user definable functions, it's because I converted a python based underscore.js library into ComfyUI Nodes, which turned out to be rather pointless without functions to connect them too.