Skip to content

Conversation

@sfinktah
Copy link
Contributor

@sfinktah sfinktah commented Nov 4, 2025

These were the changes necessary to get a Windows based build to work. There are some [possibly] superfluous checks that I attempted to strip out after, but that reintroduced a bug that caused paths in the .js import statements to look like ../../../../../../../../../this.js, so I just left it in.

The only functional difference is that this build includes an -E option which modifies comfyui/frontend's index.d.ts file to force all declarations to be exported.

I can't see how you could have ever sucessfully run it without performing that step manually anyway, but no doubt you will surprise me somehow.

This is submitted more as an explanation in detail, rather than any expectation of being merged -- though I have full confidence it will not be harmful if you do decide to merge it.

Testing

The output of npm run build was identical to what was already in the repo, excepting 6 .css files, which differed only in the line endings (unix vs windows).

@sfinktah
Copy link
Contributor Author

sfinktah commented Nov 4, 2025

If you just want the functionality of adding export to all the comfy types, I extracted that into a standalone script with a few options.

https://github.com/sfinktah/comfy-ovum/blob/1f4ca23395fccbd0ba29b0ef7a5a3b8db9623cbd/__export_frontend_types.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant