-
Notifications
You must be signed in to change notification settings - Fork 22
Resolves asking for cluster ID when it's known. #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andrej1991 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Skipping CI for Draft Pull Request. |
40a4e9a to
3a0b9dd
Compare
By examining the last 100 runs of assisted-chat eval tests in the CI the issue appeared 4 times. The description of the issue: The LLM asks for cluster ID even if the cluster was created with the previous message in the same conversation. Example: Query: Using the ID of the cluster you just created, get the Discovery ISO download URL for cluster 'eval-test-singlenode-d0xsqi07' Response: I cannot use the cluster name to get the Discovery ISO download URL. I need the cluster ID. The cluster ID is 12e392cb-82e3-43e1-9923-d627b6476f43. Would you like me to get the Discovery ISO download URL for you? Possible root cause: a) the resolution logic in lines 125-129 and the instruction in line 124 never said that the model should not verify the cluster ID or any information which can be learned from tool calls with the user after getting it from the tool calls. b) line 124 instructed the model to acquire the needed information via tool calls without saying where the logic was located. It might caused uncertainity in the model c) the query includes both cluster ID and cluster name. Having both is clearly redundant, which might cause some confusion.
3a0b9dd to
c01895b
Compare
|
@andrej1991 do you want to continue work on this? Is it still needed? |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
By examining the last 100 runs of assisted-chat eval tests in the CI the issue appeared 4 times. The description of the issue:
The LLM asks for cluster ID even if the cluster was created with the previous message in the same conversation.
Example:
Query: Using the ID of the cluster you just created, get the Discovery ISO download URL for cluster 'eval-test-singlenode-d0xsqi07'
Response: I cannot use the cluster name to get the Discovery ISO download URL. I need the cluster ID. The cluster ID is 12e392cb-82e3-43e1-9923-d627b6476f43. Would you like me to get the Discovery ISO download URL for you?
Possible root cause:
a) the resolution logic in lines 125-129 and the instruction in line 124 never said that the model should not verify the cluster ID or any information which can be learned from tool calls with the user after getting it from the tool calls.
b) line 124 instructed the model to acquire the needed information via tool calls without saying where the logic was located. It might caused uncertainity in the model
c) the query includes both cluster ID and cluster name. Having both is clearly redundant, which might cause some confusion.