add ssh output to check eval test failure

[eliajahshan]

Draft

Summary by CodeRabbit

• Tests
  • Improved cluster creation failure diagnostics with additional debug information including cluster ID, status, and platform details.
  • Enhanced Single Node OpenStack test validation with expanded parameter verification.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eliajahshan
Once this PR has been reviewed and has the lgtm label, please assign maorfr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Walkthrough

The changes enhance diagnostic capabilities in cluster creation and validation test scripts. They add detailed diagnostic output when cluster configuration mismatches are detected and when cluster creation times out, while expanding validation parameters for Single Node OpenStack test verification.

Changes

Cohort / File(s)	Summary
Cluster diagnostic enhancements test/scripts/common.sh	Added diagnostic fields (cluster ID, status, high_availability_mode, platform.type) when configuration mismatches occur; added cluster name and debug block listing matching clusters on creation timeout by querying assisted service
SNO validation expansion test/scripts/verify_create_eval_test_sno.sh	Added diagnostic message for cluster validation context; expanded wait_and_validate_cluster invocation with additional parameters (domain, single-node flag, CPU architecture, "SNO" string, SSH key)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• making the evaluation tests more stable #213 — Modifies test/eval flows and test scripts with UNIQUE_ID-aware checks, list_clusters diagnostic queries, and extra verification arguments for cluster creation/verification

Suggested reviewers

• carbonin
• keitwb
• maorfr

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title refers to 'ssh output' but the actual changes focus on adding diagnostic fields (cluster ID, status, HA mode, platform type) and expanded cluster validation parameters, not SSH output.	Revise the title to accurately reflect the main changes, such as 'Add diagnostic cluster info and expand validation parameters' or 'Improve cluster validation diagnostics'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Hi @eliajahshan. Thanks for your PR.

I'm waiting for a rh-ecosystem-edge member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

test/scripts/common.sh (1)

166-173: LGTM! Enhanced timeout diagnostics are very helpful.

The debug block that lists matching clusters will significantly improve troubleshooting when cluster creation times out. The || true ensures the script doesn't fail if the debug query encounters issues, which is appropriate.

Minor style consistency suggestions

For consistency with the rest of the file:

1. Line 170 uses curl -fsS while lines 36 and 45 use curl -sSf (same flags, different order)
2. Lines 168-169 could follow the inline style used on lines 35 and 44:

-            local service_url
-            service_url=$(get_assisted_service_url)
+            local service_url=$(get_assisted_service_url)

These are purely stylistic and don't affect functionality.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 574ee6d and 7583d05.

📒 Files selected for processing (2)

• test/scripts/common.sh
• test/scripts/verify_create_eval_test_sno.sh

🔇 Additional comments (3)

test/scripts/common.sh (1)

147-150: LGTM! Helpful diagnostic additions.

These additional diagnostic fields (cluster ID, status, high_availability_mode, platform.type) will significantly aid troubleshooting when configuration mismatches occur.

test/scripts/verify_create_eval_test_sno.sh (2)

17-17: LGTM! Clear diagnostic message.

This informational message helps users understand what's being validated and sets expectations about failure output.

---

19-26: LGTM! SSH key validation properly integrated.

The function call correctly passes all required parameters including the SSH key for validation. This aligns with the PR objective to "add ssh output to check eval test failure."

The hardcoded SSH key on line 15 appears to be a test fixture (based on the example@example.com domain), which is appropriate for a validation test script.