Skip to content

Conversation

@omertuc
Copy link
Member

@omertuc omertuc commented Jan 13, 2026

Fixes two issues with run_seed.sh:

  • etcd-defrag doesn't work with extending expiration for some reason, so it blocks us from running the script (this is probably a bug)

  • We should use newer etcd versions to support seed images coming from newer OpenShift releases.

Summary by CodeRabbit

  • Chores
    • Updated OpenShift release version from 4.13.0 to 4.22.0
    • Modified etcd defragmentation configuration during seed operations

✏️ Tip: You can customize this high-level summary in your review settings.

Fixes two issues with `run_seed.sh`:

- `etcd-defrag` doesn't work with extending expiration for some reason, so
it blocks us from running the script (this is probably

- We should use newer etcd versions to support seed images coming from
  newer OpenShift releases.
@openshift-ci openshift-ci bot requested review from danmanor and tsorya January 13, 2026 12:22
@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026

Walkthrough

The run_seed.sh script has been updated to use OpenShift release version 4.22.0-ec.0-x86_64 instead of 4.13.0-x86_64, and the --etcd-defrag flag has been removed from the cargo run command.

Changes

Cohort / File(s) Summary
Seed script configuration
run_seed.sh
Updated RELEASE_IMAGE to version 4.22.0-ec.0-x86_64; removed --etcd-defrag flag from cargo run invocation

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Make run_seed.sh work again' directly relates to the main changes: removing a failing etcd-defrag flag and updating OpenShift release versions to fix run_seed.sh functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 08e71a2 and b0933d6.

📒 Files selected for processing (1)
  • run_seed.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (2)
run_seed.sh (2)

73-144: LGTM! Removal of --etcd-defrag resolves the blocking issue.

The removal of the --etcd-defrag flag (as noted in the AI summary) addresses the conflict with --extend-expiration that was blocking script execution. Defragmentation is an optimization and not strictly required for the seed operation to function.


9-9: Verify the OpenShift 4.22.0-ec.0 release image exists and is accessible on quay.io before merging.

The script depends on this image to extract etcd metadata (line 48). Confirm that quay.io/openshift-release-dev/ocp-release:4.22.0-ec.0-x86_64 is available and accessible with your credentials. The version bump from 4.13.0 to 4.22.0-ec.0 aligns with supporting newer OpenShift seed images, but the early candidate (ec.0) tag should be verified as intended before use.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@danmanor
Copy link
Member

@omertuc What about the backup ? do we want to recreate the backup every time ?

@danmanor
Copy link
Member

/override ci/prow/e2e-aws-ovn-single-node-recert-parallel ci/prow/e2e-aws-ovn-single-node-recert-serial

@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/e2e-aws-ovn-single-node-recert-parallel, ci/prow/e2e-aws-ovn-single-node-recert-serial

Details

In response to this:

/override ci/prow/e2e-aws-ovn-single-node-recert-parallel ci/prow/e2e-aws-ovn-single-node-recert-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danmanor
Copy link
Member

/override ci/prow/ibi-e2e-flow ci/prow/ibu-e2e-flow

@danmanor
Copy link
Member

/hold

@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/ibi-e2e-flow, ci/prow/ibu-e2e-flow

Details

In response to this:

/override ci/prow/ibi-e2e-flow ci/prow/ibu-e2e-flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danmanor
Copy link
Member

/override ci/prow/e2e-aws-ovn-single-node-recert-parallel ci/prow/e2e-aws-ovn-single-node-recert-serial

@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/e2e-aws-ovn-single-node-recert-parallel, ci/prow/e2e-aws-ovn-single-node-recert-serial

Details

In response to this:

/override ci/prow/e2e-aws-ovn-single-node-recert-parallel ci/prow/e2e-aws-ovn-single-node-recert-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omertuc
Copy link
Member Author

omertuc commented Jan 13, 2026

/retest

3 similar comments
@omertuc
Copy link
Member Author

omertuc commented Jan 13, 2026

/retest

@omertuc
Copy link
Member Author

omertuc commented Jan 13, 2026

/retest

@omertuc
Copy link
Member Author

omertuc commented Jan 14, 2026

/retest

@omertuc
Copy link
Member Author

omertuc commented Jan 15, 2026

/unhold

@omertuc
Copy link
Member Author

omertuc commented Jan 15, 2026

/retest

@omertuc
Copy link
Member Author

omertuc commented Jan 16, 2026

/retest ibi-e2e-flow

@openshift-ci
Copy link

openshift-ci bot commented Jan 16, 2026

@omertuc: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test 4.14-images
/test 4.15-images
/test 4.16-images
/test 4.17-images
/test baremetalds-sno-recert-cluster-rename
/test cargo-check
/test cargo-clippy
/test cargo-test
/test e2e-aws-ovn-single-node-recert-openshift-e2e-test-qe
/test e2e-aws-ovn-single-node-recert-parallel
/test e2e-aws-ovn-single-node-recert-serial
/test ibi-e2e-flow
/test ibu-e2e-flow
/test images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-rh-ecosystem-edge-recert-main-4.14-images
pull-ci-rh-ecosystem-edge-recert-main-4.15-images
pull-ci-rh-ecosystem-edge-recert-main-4.16-images
pull-ci-rh-ecosystem-edge-recert-main-4.17-images
pull-ci-rh-ecosystem-edge-recert-main-baremetalds-sno-recert-cluster-rename
pull-ci-rh-ecosystem-edge-recert-main-cargo-check
pull-ci-rh-ecosystem-edge-recert-main-cargo-clippy
pull-ci-rh-ecosystem-edge-recert-main-cargo-test
pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-parallel
pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-serial
pull-ci-rh-ecosystem-edge-recert-main-ibi-e2e-flow
pull-ci-rh-ecosystem-edge-recert-main-ibu-e2e-flow
pull-ci-rh-ecosystem-edge-recert-main-images
Details

In response to this:

/retest ibi-e2e-flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omertuc
Copy link
Member Author

omertuc commented Jan 16, 2026

/test ibi-e2e-flow

@omertuc
Copy link
Member Author

omertuc commented Jan 17, 2026

/override ?

@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2026

@omertuc: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • CodeRabbit
  • ci/prow/4.14-images
  • ci/prow/4.15-images
  • ci/prow/4.16-images
  • ci/prow/4.17-images
  • ci/prow/baremetalds-sno-recert-cluster-rename
  • ci/prow/cargo-check
  • ci/prow/cargo-clippy
  • ci/prow/cargo-test
  • ci/prow/e2e-aws-ovn-single-node-recert-parallel
  • ci/prow/e2e-aws-ovn-single-node-recert-serial
  • ci/prow/ibi-e2e-flow
  • ci/prow/ibu-e2e-flow
  • ci/prow/images
  • pull-ci-rh-ecosystem-edge-recert-main-4.14-images
  • pull-ci-rh-ecosystem-edge-recert-main-4.15-images
  • pull-ci-rh-ecosystem-edge-recert-main-4.16-images
  • pull-ci-rh-ecosystem-edge-recert-main-4.17-images
  • pull-ci-rh-ecosystem-edge-recert-main-baremetalds-sno-recert-cluster-rename
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-check
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-clippy
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-test
  • pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-parallel
  • pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-serial
  • pull-ci-rh-ecosystem-edge-recert-main-ibi-e2e-flow
  • pull-ci-rh-ecosystem-edge-recert-main-ibu-e2e-flow
  • pull-ci-rh-ecosystem-edge-recert-main-images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omertuc
Copy link
Member Author

omertuc commented Jan 18, 2026

/override pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-parallel

@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2026

@omertuc: Overrode contexts on behalf of omertuc: ci/prow/e2e-aws-ovn-single-node-recert-parallel

Details

In response to this:

/override pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-parallel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omertuc
Copy link
Member Author

omertuc commented Jan 18, 2026

/override pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-serial

@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2026

@omertuc: Overrode contexts on behalf of omertuc: ci/prow/e2e-aws-ovn-single-node-recert-serial

Details

In response to this:

/override pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2026

@omertuc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/baremetalds-sno-recert-cluster-rename b0933d6 link unknown /test baremetalds-sno-recert-cluster-rename

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants