Skip to content

create GlobalConfigFiles.xml#1

Open
darachcawley wants to merge 2 commits intorhappdev:masterfrom
darachcawley:master
Open

create GlobalConfigFiles.xml#1
darachcawley wants to merge 2 commits intorhappdev:masterfrom
darachcawley:master

Conversation

@darachcawley
Copy link
Copy Markdown

as suggested by @misanche

@darachcawley darachcawley requested a review from misanche October 24, 2019 10:08
@darachcawley
Copy link
Copy Markdown
Author

@misanche do you think this is worth adding?

@misanche
Copy link
Copy Markdown
Contributor

HI @darachcawley, sorry for the late reply... I'm a bit busy right now, Yes I think that's a good idea, at least we have an example, to work with.

Probably we can explore also, adding init.groovy.d folder inside the repo and make a groovy script that picks the value from the repo and creates that file with the desired repo url.

I have several examples that we did in the innovation labs and maybe worths looking into it.

@misanche
Copy link
Copy Markdown
Contributor

To approve the MR, maybe it's better to place a PLACEHOLDER instead of your nexus url.

<mirror>
<id>Nexus</id>
<name>Nexus Public Mirror</name>
<url>http://nexus-dcawley-xpaas.apps.na311.openshift.opentlc.com/content/groups/public/</url>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the URL with a PLACEHOLDER

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants