add MCP container healthiness test to be used on Konflux. #1
Merged
samdoran merged 2 commits intorhel-lightspeed:mainfrom Feb 6, 2026
Merged
add MCP container healthiness test to be used on Konflux. #1samdoran merged 2 commits intorhel-lightspeed:mainfrom
samdoran merged 2 commits intorhel-lightspeed:mainfrom
Conversation
Contributor
Author
|
@samdoran here is the example of the successful IntegrationTest run |
r0x0d
approved these changes
Feb 4, 2026
Member
|
Wow, this is pretty crazy. Very impressive work! I do wonder if using HTTP transport would make testing any easier and remove the need to create pipes to interact with the application. My only other concern is troubleshooting this if there are failures. I somewhat understand it today after reading through it for a bit, but 3-6 months from now I will probably have long forgotten how all the plumbing works. |
Member
|
I removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last time there was the strong feedback ~"no scripts included in pipelines/tasks". Keeping that in mind, let me note that a script in the
argssection oftasks/mcp-protocol-audit.yamlit is not just "reasonable", but it is arguably the most technically sound approach for the given CI pipeline.Sincerely, I tried to move that script out of the sidecar logic, but that would require something like
which looks like an overkill at first place, and I didn't go that further to ensure it would work.
After this PR is merged, and the container is renewed on quay.io, the integration test configuration should be updated accordingly, ideally not in Konflux directly where it currently lives nowadays for testing purposes.