Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
subpop
force-pushed
the
feat/update-architecture-with-flow-diagrams
branch
2 times, most recently
from
d826448 to
da193af
Compare
Add more details about how tools are called and where the various components typically run.
subpop
force-pushed
the
feat/update-architecture-with-flow-diagrams
branch
from
da193af to
778624a
Compare
Member
|
I think adding more detailed documentation is good. All of the assertions about stdio will need to be updated once we add support for the HTTP transport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand
architecture.mdwith more detail explaining the deployment topology (where and how components are expected to run) and a flow chart that details the call stack flow the various layers of code. This might be more detail than necessary for the top-levelarchitecture.mddoc, maybe?