Skip to content

Handling the failure gracefully on BUY or SELL#127

Open
sourcepirate wants to merge 1 commit intorhettre:mainfrom
sourcepirate:main
Open

Handling the failure gracefully on BUY or SELL#127
sourcepirate wants to merge 1 commit intorhettre:mainfrom
sourcepirate:main

Conversation

@sourcepirate
Copy link

Currently we get a type error for buy or sell since the "success_response" is referenced directly on the order_response.
image

The following PR check for the "success_response" to handle a generic buy or sell exception.

@sourcepirate
Copy link
Author

sourcepirate commented Apr 6, 2025

TEST LOG:

2025-04-06 13:23:58,146 - coinbase_advanced_trader - INFO - Fetching fresh account data from Coinbase
2025-04-06 13:23:58,146 - coinbase_advanced_trader - INFO - Fetching fresh account data from Coinbase
.2025-04-06 13:23:58,147 - coinbase_advanced_trader - WARNING - No account found for NON_EXISTENT
.2025-04-06 13:23:58,147 - coinbase_advanced_trader - INFO - Fetching fresh account data from Coinbase
.2025-04-06 13:23:58,147 - coinbase_advanced_trader - INFO - Retrieved balance for BTC: 1.5
2025-04-06 13:23:58,147 - coinbase_advanced_trader - INFO - Retrieved balance for ETH: 10.0
2025-04-06 13:23:58,147 - coinbase_advanced_trader - WARNING - No account found for XRP
2025-04-06 13:23:58,147 - coinbase_advanced_trader - INFO - Retrieved balance for XRP: 0
.2025-04-06 13:23:58,147 - coinbase_advanced_trader - INFO -
Accounts with Balance:
2025-04-06 13:23:58,147 - coinbase_advanced_trader - INFO -
  BTC:
    Balance: 1.5 BTC
    UUID: abc123
    ----------------------
2025-04-06 13:23:58,147 - coinbase_advanced_trader - INFO -
  XRP:
    Balance: 100.0 XRP
    UUID: ghi789
    ----------------------
..2025-04-06 13:23:58,148 - coinbase_advanced_trader.alphasquared_trader - INFO - Current BTC Risk: 30
2025-04-06 13:23:58,148 - coinbase_advanced_trader.alphasquared_trader - INFO - Strategy suggests: Action = BUY, Value = 100
2025-04-06 13:23:58,148 - coinbase_advanced_trader.alphasquared_trader - INFO - Buy limit order placed: ID=123, Size=0.001, Price=50000
.2025-04-06 13:23:58,148 - coinbase_advanced_trader.alphasquared_trader - INFO - Current BTC Risk: 70
2025-04-06 13:23:58,148 - coinbase_advanced_trader.alphasquared_trader - INFO - Strategy suggests: Action = SELL, Value = 50
2025-04-06 13:23:58,148 - coinbase_advanced_trader.alphasquared_trader - INFO - Current BTC balance: 1.0
2025-04-06 13:23:58,148 - coinbase_advanced_trader.alphasquared_trader - INFO - Current BTC price: 50000 USDC
2025-04-06 13:23:58,148 - coinbase_advanced_trader.alphasquared_trader - INFO - Sell amount: 0.50000000 BTC
2025-04-06 13:23:58,148 - coinbase_advanced_trader.alphasquared_trader - INFO - Sell limit order placed for 0.50000000 BTC at 50250.00 USDC: Order(id='456', product_id='BTC-USDC', side=<OrderSide.SELL: 'sell'>, type=<OrderType.LIMIT: 'limit'>, size=Decimal('0.5'), price=Decimal('50250'), client_order_id=None, status='pending')
.........2025-04-06 13:23:58,154 - coinbase_advanced_trader - INFO - FGI schedule successfully updated.
.....2025-04-06 13:23:58,157 - coinbase_advanced_trader - INFO - FGI retrieved: 25 (Extreme Fear) for trading BTC-USDC
2025-04-06 13:23:58,157 - coinbase_advanced_trader - INFO - FGI condition met: FGI 25 buy condition. Executing buy with adjusted amount 12.00
.2025-04-06 13:23:58,158 - coinbase_advanced_trader - INFO - FGI retrieved: 50 (Neutral) for trading BTC-USDC
2025-04-06 13:23:58,158 - coinbase_advanced_trader - WARNING - No trading condition met for FGI: 50
.2025-04-06 13:23:58,158 - coinbase_advanced_trader - INFO - FGI retrieved: 75 (Extreme Greed) for trading BTC-USDC
2025-04-06 13:23:58,158 - coinbase_advanced_trader - INFO - FGI condition met: FGI 75 sell condition. Executing sell with adjusted amount 8.00
.2025-04-06 13:23:58,159 - coinbase_advanced_trader.services.funds_service - INFO -
Initiating Deposit:
  Account: acc123
  Payment Method: pm123
  Amount: 25.00 USD
  Commit: True
2025-04-06 13:23:58,159 - coinbase_advanced_trader.services.funds_service - INFO -
Deposit Response:
  Transaction ID: dep123
  Status: pending
  Amount:
    Requested: 25.00 USD
    Native: None None
  Fee: None None
  Reference: test_deposit
  Details:
    Instant: False
    Committed: True
    Created At: None
    Updated At: None
    Payout At: None
2025-04-06 13:23:58,159 - coinbase_advanced_trader.services.funds_service - INFO -
Full Response Payload:
{
  "data": {
    "amount": {
      "amount": "25.00"
    },
    "committed": true,
    "id": "dep123",
    "instant": false,
    "status": "pending",
    "user_reference": "test_deposit"
  }
}
....2025-04-06 13:23:58,159 - coinbase_advanced_trader - INFO - Starting limit order placement - Side: OrderSide.BUY, Product: BTC-USDC
2025-04-06 13:23:58,159 - coinbase_advanced_trader - INFO - Successfully placed a limit buy order for 10.00 USDC of BTC (~0.00020010 BTC) at 49975.00 USDC
.2025-04-06 13:23:58,159 - coinbase_advanced_trader - INFO - Starting limit order placement - Side: OrderSide.SELL, Product: BTC-USDC
2025-04-06 13:23:58,159 - coinbase_advanced_trader - INFO - Successfully placed a limit sell order for 10.00 USDC of BTC (~0.00019900 BTC) at 50250.00 USDC
.2025-04-06 13:23:58,160 - coinbase_advanced_trader - INFO - Successfully placed a market buy order for 10.00 USDC of BTC (~0.00020000 BTC) at 50000.00 USDC
.2025-04-06 13:23:58,160 - coinbase_advanced_trader - INFO - Successfully placed a market sell order for 10.00 USDC of BTC (~0.00020000 BTC) at 50000.00 USDC
..2025-04-06 13:23:58,161 - coinbase_advanced_trader - INFO - Starting limit order placement - Side: OrderSide.BUY, Product: BTC-USDC
2025-04-06 13:23:58,161 - coinbase_advanced_trader - INFO - Successfully placed a limit buy order for 10.00 USDC of BTC (~0.00020010 BTC) at 49975.00 USDC
...2025-04-06 13:23:58,163 - coinbase_advanced_trader - ERROR - Required fields missing in response for BTC-USDC
...2025-04-06 13:23:58,163 - coinbase_advanced_trader - WARNING - Invalid action: invalid_action
2025-04-06 13:23:58,163 - coinbase_advanced_trader - ERROR - Invalid FGI schedule. Update rejected.
.2025-04-06 13:23:58,163 - coinbase_advanced_trader - INFO - FGI schedule is valid.
2025-04-06 13:23:58,163 - coinbase_advanced_trader - INFO - FGI schedule is valid.
2025-04-06 13:23:58,163 - coinbase_advanced_trader - INFO - FGI schedule updated.
.
----------------------------------------------------------------------
Ran 41 tests in 0.018s

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant