fix: remove toEthSignedMessage on 1271 #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes signature validation for ERC-1271 by removing the use of toEthSignedMessageHash when validating ERC-1271 signatures and adding it only for UserOperation validation where it's required.
- Split the signature utility function into
signHash(for raw hash signing) andsignUserOpHash(for UserOperation hash signing with Ethereum message prefix) - Updated signature validation logic to apply Ethereum message hash formatting only for UserOperations, not for ERC-1271 validation
- Updated test imports to use the appropriate signing function based on the validation context
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/utils/Signature.sol | Splits signing function into signHash for raw signatures and signUserOpHash for UserOperation signatures |
| src/OwnableValidator/OwnableValidator.sol | Moves toEthSignedMessageHash application to UserOperation validation only, removes it from ERC-1271 validation |
| src/MultiFactor/MultiFactor.sol | Applies toEthSignedMessageHash only for UserOperation validation |
| Multiple test files | Updates imports to use appropriate signing function based on validation context |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.