Skip to content

Add pub key to CredentialAdded event (WebauthValidator) #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kopy-kat merged 2 commits into from
Sep 15, 2025
Merged

Add pub key to CredentialAdded event (WebauthValidator) #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f832e97
add pub key to CredentialAdded event
egillh210 Sep 15, 2025
2e1a591
lint sol file
egillh210 Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/WebAuthnValidator/WebAuthnValidator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,10 @@ contract WebAuthnValidator is ERC7579HybridValidatorBase {
/// @notice Emitted when a credential is added to an account
/// @param account The address of the smart account
/// @param credentialId The ID of the added credential
event CredentialAdded(address indexed account, bytes32 indexed credentialId);
/// @param credential The WebAuthn credential
event CredentialAdded(
address indexed account, bytes32 indexed credentialId, WebAuthnCredential credential
);

/// @notice Emitted when a credential is removed from an account
/// @param account The address of the smart account
Expand Down Expand Up @@ -202,7 +205,7 @@ contract WebAuthnValidator is ERC7579HybridValidatorBase {
}

// Emit event
emit CredentialAdded(account, credId);
emit CredentialAdded(account, credId, _credentials[i]);

// Cache the credential ID
require(credentialId < credId, NotSorted());
Expand Down Expand Up @@ -303,7 +306,11 @@ contract WebAuthnValidator is ERC7579HybridValidatorBase {
revert CredentialAlreadyExists();
}

emit CredentialAdded(account, credentialId);
emit CredentialAdded(
account,
credentialId,
WebAuthnCredential({ pubKeyX: pubKeyX, pubKeyY: pubKeyY, requireUV: requireUV })
);
}

/// @notice Removes a WebAuthn credential from the account
Expand Down
Loading