Skip to content

Conversation

@Dhruv-Mishra
Copy link
Contributor

As discussed in #109

@Dhruv-Mishra
Copy link
Contributor Author

@kopy-kat, the tests for OwnableValidator Module are failing. No evident changes in this repo.
I was unable to find the source code for the relevant contract on Sepolia Etherscan. or in smartsessions repo

@kopy-kat
Copy link
Member

hmm yeah this is really weird, this is the source code: https://github.com/rhinestonewtf/core-modules/blob/main/src/OwnableValidator/OwnableValidator.sol

@Dhruv-Mishra
Copy link
Contributor Author

Dhruv-Mishra commented Jan 29, 2025

hmm yeah this is really weird, this is the source code: https://github.com/rhinestonewtf/core-modules/blob/main/src/OwnableValidator/OwnableValidator.sol

There haven't been any recent changes within the code. It might be that an owner was explicitly added to the owners linked list declared here using the addOwners method

Should I update the tests to expect one element? Or should I run removeOwner once to remove the currently added owner?

@kopy-kat
Copy link
Member

yeah this feels like it is the case, expecting one element should be fine

@Dhruv-Mishra
Copy link
Contributor Author

yeah this feels like it is the case, expecting one element should be fine

Updated

@Dhruv-Mishra Dhruv-Mishra changed the title Added Action Policy Fallback Constants feat: added action policy fallback constants Feb 2, 2025
@kopy-kat kopy-kat merged commit aa03585 into rhinestonewtf:main Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants