-
Notifications
You must be signed in to change notification settings - Fork 39
refactor: remove account dependencies #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove account dependencies #161
Conversation
|
@kopy-kat a few issues:
|
|
Should we remove registry dep too? |
done but the 7702 compatibility change added to 7579 ref requries ^0.8.24 for tstore too (we can precompile this tho), but the 4337 repo is ^0.8.23 too maybe lets just keep it >=0.8.24 <0.9.0 ? |
|
Yeah that’s mid, maybe we remove the 7579 impl too - but yeah maybe we need to stay higher than 0.8.24 |
7579 ref is removed, bumped solc to 0.8.24 >= All in all this pr removes the kernel, safe7579, 7579ref and registry dependecies |
|
I'm kind of having doubts over essentially scrapping dependencies and needing to manually port over changes. These should be rare tho so it might be fine - wdyt @highskore |
I think it's fine since it's audited contracts which should in theory only update rarely and the porting is not that bad (just updating bytecode most of the time) |
|
@kopy-kat Found a nested dependency to erc7579 inside module-bases, do we remove the dependency? We would need to duplicate some code, it's stopping modulekit for being able to use solc 0.8.23 because of the tstore inside latest erc7579 ref. If not - We could bring back the erc7579 dep here or just merge so I can resolve the conflicts on the downgrade-solc branch and close the PRs |
kopy-kat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me - I think we should release it as a new major version
before merging could you try using this branch in core-modules and seeing if anything breaks?
solves #158 to make #160 work