fix: linkify the whole Download button#76
Open
Crystal-RainSlide wants to merge 2 commits intorhino-linux:mainfrom
Open
fix: linkify the whole Download button#76Crystal-RainSlide wants to merge 2 commits intorhino-linux:mainfrom
Crystal-RainSlide wants to merge 2 commits intorhino-linux:mainfrom
Conversation
Member
|
@Crystal-RainSlide major apologies that this has gone unnoticed for so long, it is clearly useful. Would you be able to rebase on the latest branch so we can merge it in? (I could of course make the change myself but want you to get commit credits) |
Crystal-RainSlide
force-pushed
the
fix-download-btn
branch
from
0e62c5b to
3f0eaf5
Compare
Author
|
@oklopfer Done, but, well, now there is one more fix (to make React happy) and you might want to test that! |
ajstrongdev
requested changes
Feb 14, 2026
Crystal-RainSlide
force-pushed
the
fix-download-btn
branch
from
39330b0 to
b2ada33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix, only the text on the Download button is a link, and clicking anywhere on the btn but out of the text would lead to nothing. Move the button into the
<a>fixes this problem.Move classNames of
<a>s to the start & fix the indent by the way.(Actually the
<button>can be skipped without much compromise if you addrole="button"to the<a>.)