tests: Make kdump/crash-sysrq-c skip vmcore checking

[coiby]

The 2nd part of kdump/crash-sysrq-c test will check for the existence of dumped vmcore by default. But it only works for local dumping. For NFS/SSH dumping, PANIC_VMCORE_CHECK=false will be needed to skip it.

Since we already use analyse-crash-cmd/simple_check, apply PANIC_VMCORE_CHECK=false to all test plans.

Note current NFS/SSH test plans don't fail because currently kdump/crash-sysrq-c skips the 2nd part of test but this will be fixed by https://gitlab.com/redhat/centos-stream/tests/kernel/kernel-tests/-/merge_requests/4550

[gemini-code-assist]

Summary of Changes

Hello @coiby, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the test configuration for kdump/crash-sysrq-c tests by introducing a specific environment variable. This modification ensures that the tests correctly handle scenarios involving remote vmcore dumping, preventing unnecessary failures by bypassing the default local vmcore verification process.

Highlights

• Test Configuration Update: Modified the kernel-tests-plans/main.fmf file to introduce an envrioment section, setting PANIC_VMCORE_CHECK to false.
• VMcore Checking Disabled: This change explicitly disables the default vmcore existence check for kdump/crash-sysrq-c tests, which is necessary for remote dumping scenarios like NFS/SSH.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• kernel-tests-plans/main.fmf
  • Added an envrioment block with PANIC_VMCORE_CHECK: false.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to skip vmcore checking in the kdump/crash-sysrq-c test for non-local dumping scenarios by setting PANIC_VMCORE_CHECK=false. I've identified a critical typo in the configuration file that would prevent this setting from being applied, effectively nullifying the intended change. Please see the detailed comment for the correction.