fix(downloader): sanitize filenames and handle existing files gracefully #1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I created the file hash check feature so that the findFile function, which is expensive to execute, is not called by default. |
- Add sanitizeFileName() to replace invalid SAF characters (: * ? " < > | / \) with underscores - Fix NullPointerException when createDirectory() or createFile() returns null - Handle existing files gracefully: show "already downloaded" instead of crashing - Works regardless of file_hash_check setting
john-doe-coding
force-pushed
the
fix/sanitize-download-filenames
branch
from
474a123 to
2807385
Compare
Author
|
@rhunk addressed, let me know if the new approach addresses your concern, or if you'd like to see any other changes. |
Owner
|
I saw that paths are already sanitized in DownloadRequest.kt#L41-L44. There is no need to add a new sanitize function. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloads were crashing when story/highlight names contained characters like
:)(e.g., "A_day_in_my_life:)"). SAF doesn't allow these characters, socreateDirectory()returns null and we'd get a NullPointerException.Also fixed a related issue where re-downloading the same file would crash if
file_hash_checkwas disabled, sincecreateFile()returns null for existing files.Changes:
sanitizeFileName()that replaces invalid characters (: * ? " < > | / \) with underscores!!with proper null checks and descriptive error messages