Skip to content

refactor: trim agents to production/ + simulation/, drop site-sim#11

Merged
richsak merged 3 commits intodevfrom
feat/agents-trim
Apr 26, 2026
Merged

refactor: trim agents to production/ + simulation/, drop site-sim#11
richsak merged 3 commits intodevfrom
feat/agents-trim

Conversation

@richsak
Copy link
Copy Markdown
Owner

@richsak richsak commented Apr 26, 2026

Summary

  • Drops the unused site-sim substrate (9 agent specs, demo-sites/northwest-reno/, scripts/run-simulation-site.ts, the webster-site-sim halves of the sim-agents and memory-stores manifests) and the orphan genealogy-spawned visual-design-critic so production lands at a clean 9-spec set.
  • Reorganizes agents/*.json into agents/production/ and agents/simulation/ (9 specs each, 1:1 symmetric) with validate-agents.ts recursing through agents/** so the strict Ajv schema gate is preserved.
  • Aligns root AGENTS.md, README.md (7→9 + full architecture diagram + repo-layout block), and context/VISION.md (drops dual-substrate framing, memory-store count 12→6, single-substrate scope lock).

Validation

bun run validate is green: 19 valid agent/env specs, 7 valid findings, 0 lint warnings, 0 type errors, 0 markdown errors, 175 tests pass / 0 fail.

Hackathon framing

The story for judges is now sharper: production is exactly the 9-agent council that runs Nicolette's live LP weekly; agents/simulation/ mirrors it 1:1 to drive the timelapse demo. No second-substrate half-finished surface.

Merge-order coordination

Recommend this PR merges to dev before feat/repo-polish Section B (the upcoming agents/README.md PR), so that README is written against the new agents/{production,simulation}/ layout.

Test plan

  • bun run validate green locally
  • CI green on push
  • Reviewer spot-checks: production set still 9 specs that the live council can register; sim set still 9 specs MCP-native; no webster-site-sim / northwest-reno / licensing-and-warranty-critic references remain in functional code or the judge-facing surface

🤖 Generated with Claude Code

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 26, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • main
  • review/empty-base

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f6625ee0-34c6-4752-96f4-e1225012a00b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/agents-trim

Comment @coderabbitai help to get the list of available commands and usage tips.

richsak and others added 3 commits April 26, 2026 16:57
Trims Webster's agent surface to a single substrate ahead of the
hackathon submission. Site-sim was committed but unused by the demo
video. visual-design-critic was a runtime genealogy spawn with no
id.txt registration and no production orchestrator references, so
removing it brings production back to a clean 9-agent set that
mirrors the 9-spec LP-sim set 1:1.

Deletions: 9 site-sim agent specs, demo-sites/northwest-reno/,
scripts/run-simulation-site.ts, agents/visual-design-critic.json,
package.json sim:site, sim-agents.json + memory-stores.json site
halves. run-simulation.ts collapses to lp-only literal types and a
single-page screenshot path. register-sim-agents.ts/sim-preflight.ts
expectations drop from 18→9 sim specs, 2→1 substrate. sim-council.md
fan-out drops the SUBSTRATE/AGENT_SET site case and the
licensing-and-warranty-critic arm. Affected tests rewritten to
LP-only assertions; no tests deleted outright.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Splits the flat agents/*.json layout into two subdirectories so the
operational role of each spec is obvious from the path:
- agents/production/ — 9 specs that run Nicolette's live council
- agents/simulation/ — 9 specs that drive the LP timelapse demo

The two sets are now 1:1 symmetric. validate-agents.ts and the
schema test recurse through agents/** so the strict Ajv schema gate
is preserved without any weakening. Hardcoded paths in
critic-genealogy.ts, planner-invoke.ts, and the affected tests are
updated to the subdir layout. Genealogy spawns now write into
agents/production/ so runtime-spawned critics land beside the rest
of the production set. agents/AGENTS.md updated to describe the
new shape; agents/CLAUDE.md follows via the existing symlink.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Updates the judge-facing surface and the canonical north-star docs
to match the new single-substrate, 9-agent shape:

- README pitch (7→9 agents), architecture diagram now shows the
  full 7-session fan-out (5 critics + monitor + visual-reviewer),
  repo layout reflects agents/{production,simulation}/, submission
  notes report 9 specs and 175 tests
- AGENTS.md mission says single-substrate Richer Health LP demo
  and points the do-not-touch rule at agents/production/
- context/VISION.md drops the dual-substrate framing: the demo arc
  is LP-only, memory store count is 6 not 12, the API cost note
  scales to one substrate, and the locked/out-of-scope sections
  reflect the cut

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@richsak richsak merged commit 944c4ed into dev Apr 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant