Skip to content

feat(skill): webster-onboarding v2 with verify scripts#12

Merged
richsak merged 3 commits intodevfrom
feat/repo-polish
Apr 27, 2026
Merged

feat(skill): webster-onboarding v2 with verify scripts#12
richsak merged 3 commits intodevfrom
feat/repo-polish

Conversation

@richsak
Copy link
Copy Markdown
Owner

@richsak richsak commented Apr 26, 2026

Summary

Implements the P0–P5 onboarding phase model locked in context/ONBOARDING-CASE-STUDY.md (Q1–Q15). The skill is a thin shell over scripts/onboarding/* and the runtime registration patterns in prompts/first-wbs-session.md, with status-file resume and machine-checked phase exit gates.

  • skills/webster-onboarding/SKILL.md — P0 overview → P5 first council, ! pre-load checks, hard security rules
  • skills/webster-onboarding/references/ — qa-bank, business-yaml-schema, key-handling, remediation, empire-fixture
  • scripts/onboarding/verify-env.ts — reads .env.local, hits Anthropic/GitHub/Cloudflare verify endpoints without echoing key values
  • scripts/onboarding/verify-all.ts — rollup with --phase {p3,p4}, agent count derived dynamically from agents/*.json non-sim specs
  • scripts/onboarding/scaffold-repo.ts — creates GitHub repo + Astro starter from context/business.yaml
  • package.json — wires onboarding:verify-env, :verify-all, :scaffold-repo
  • context/ONBOARDING-CASE-STUDY.md — fixes 9-vs-10 production agent count drift (3 spots)

Test plan

  • bun run validate — type-check, lint (0 warnings), format, agent specs (29 valid), findings (7 valid), markdownlint (0 errors), 181/181 tests pass
  • Smoke test: verify-env with no .env.local → exit 1, clean error + hint
  • Smoke test: verify-all --phase p3 → per-check ✓/✗, exit 1 on real env gaps
  • End-to-end skill invocation against Empire fixture (follow-up dry-run before recording)
  • scaffold-repo end-to-end (side-effecting — needs intentional test repo target)

Notes

  • Skill location is skills/webster-onboarding/ (matches deleted v1 path + EXPANSION-TASKS T12). The stale webster-decision-log.md reference to .claude/skills/onboard-smb/ is out of date.
  • bun run wrapper sometimes prints error: script ... exited with code 1 while the wrapper itself returns 0. Direct bun scripts/onboarding/*.ts returns the correct exit code; the skill's gate logic checks the script output, not just exit code.
  • Out of scope of this PR (separate work): T13 Empire ugly site fork, context/brand-corpus/ population, dad consent artifact.

🤖 Generated with Claude Code

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 26, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • main
  • review/empty-base

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9098908e-aac9-45c7-b731-550add9789b4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/repo-polish

Comment @coderabbitai help to get the list of available commands and usage tips.

richsak added a commit that referenced this pull request Apr 26, 2026
- README: add a "The `wbs` alias" section under Prerequisites so judges
  who clone the repo can replicate the dispatcher launcher (or run the
  equivalent `claude --settings ...` directly without aliasing).
- Untrack `deploy/webster-dispatcher.plist`. The launchd plist hardcodes
  Richie's macOS user paths (`/Users/richiesakhon/...`) so it cannot be
  shipped publicly. Preserved in `~/Vault/Projects/webster/internal-tracking/deploy/`.
- Run `bun run format` to fix prettier table-padding in
  `context/ONBOARDING-CASE-STUDY.md` (PR #12 CI format-check failure).
richsak and others added 3 commits April 26, 2026 17:00
Section A polish — pre-judging cleanup. Moved internal-only docs to
~/Vault/Projects/webster/internal-tracking/ (preserved locally, removed
from public tree).

Untracked from context/:
  EXPANSION-TASKS.md, E2E-IMPLEMENTATION-TRACKER.md, SITE-FORK-CHECKLIST.md,
  ROADMAP.md, VIDEO-PLAN.md, VIDEO-PLAN-90s.md, v2-design.md

Untracked from prompts/ (only first/second-wbs and sim-council stay public,
matching what README documents):
  third-wbs-session.md, fourth-wbs-session.md, sim-audit-fix-session.md,
  composition-session.md, e2e-demo-run-session.md, sim-runner.md

Untracked from history/:
  AGENTS.md (+ CLAUDE.md symlink)

Untracked .forge/ralph/ — already gitignored for new dispatches; old PRDs
were still in the index. Forge workflow YAMLs and config remain tracked.

AGENTS.md updated to redirect EXPANSION-TASKS references to the vault path
and drop stale doc references.
Implements the P0–P5 phase model locked in context/ONBOARDING-CASE-STUDY.md
(Q1–Q15). Skill is a thin shell over scripts/onboarding/* and the runtime
registration patterns in prompts/first-wbs-session.md, with status-file
resume and machine-checked phase exit gates.

- skills/webster-onboarding/SKILL.md — orchestration, P0 overview through
  P5 first council, ! pre-load checks, hard rules on key handling
- references/{qa-bank,business-yaml-schema,key-handling,remediation,
  empire-fixture}.md — detail split per skill-authoring conventions
- scripts/onboarding/verify-env.ts — reads .env.local, hits Anthropic /
  GitHub / Cloudflare verify endpoints without echoing key values
- scripts/onboarding/verify-all.ts — rollup with --phase {p3,p4}, agent
  count derived dynamically from agents/*.json non-sim specs
- scripts/onboarding/scaffold-repo.ts — creates GitHub repo + Astro
  starter using brand identity from context/business.yaml
- package.json — wire onboarding:verify-env, :verify-all, :scaffold-repo
- context/ONBOARDING-CASE-STUDY.md — fix 9-vs-10 production agent drift

Smoke-tested verify-env (exit 1 on missing .env.local with clean hint)
and verify-all --phase p3 (per-check ✓/✗, exit 1 on real env gaps).
End-to-end skill invocation and scaffold-repo (side-effecting) untested
— follow up via Empire dry-run before recording.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- README: add a "The `wbs` alias" section under Prerequisites so judges
  who clone the repo can replicate the dispatcher launcher (or run the
  equivalent `claude --settings ...` directly without aliasing).
- Untrack `deploy/webster-dispatcher.plist`. The launchd plist hardcodes
  Richie's macOS user paths (`/Users/richiesakhon/...`) so it cannot be
  shipped publicly. Preserved in `~/Vault/Projects/webster/internal-tracking/deploy/`.
- Run `bun run format` to fix prettier table-padding in
  `context/ONBOARDING-CASE-STUDY.md` (PR #12 CI format-check failure).
@richsak richsak merged commit 8750591 into dev Apr 27, 2026
5 checks passed
@richsak richsak deleted the feat/repo-polish branch April 27, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant