fix(ci): install ImageMagick + Playwright Chromium in test job#14
Merged
fix(ci): install ImageMagick + Playwright Chromium in test job#14
Conversation
The validate job's "Run tests" step was failing on dev with two missing-binary errors: - `magick` not in $PATH — visual-assets / heatmap rendering shells out to ImageMagick. Ubuntu runners do not include it by default. - Playwright Chromium executable missing — browser-audit tests launch Chromium via Playwright. The bundled `playwright` package needs an explicit `playwright install` to fetch the headless browser. Adds both as steps before "Run tests" so the dev/main baseline goes green again and downstream PRs stop inheriting the red.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Ubuntu's `imagemagick` package ships v6 binaries (convert, mogrify),
not v7's unified `magick` entrypoint. scripts/build-demo-manifest.ts
calls `execFileSync("magick", ...)` so the v7 name is required.
Symlink `magick` -> `$(which convert)` after the apt install. The
chained-argv syntax we use is v6-compatible.
The apt imagemagick package provides v6-only binaries. The repo uses v7 multi-call dispatch (magick, magick identify, ...) which v6 cannot satisfy via convert symlinks. Pull the v7 portable binary from the official ImageMagick release and drop it into /usr/local/bin.
Portable ImageMagick 7 binary URL was 404 — no canonical 'magick' static release exists at imagemagick.org. Switch back to apt's v6 install and add a small bash dispatcher at /usr/local/bin/magick that forwards to the v6 binary based on the subcommand. Handles 'magick (...)', 'magick identify ...', and the other tools the repo uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
validatejob's "Run tests" step has been failing ondevfor a while with two missing-binary errors:magicknot in $PATH — heatmap renderer inscripts/visual-assets.tsshells out to ImageMagick. Ubuntu runners don't include it by default.browser-audittests launch Chromium via Playwright. The bundled package needs an explicitplaywright installto fetch the headless browser.Adds both as steps before "Run tests" so the dev baseline goes green again and downstream PRs stop inheriting the red CI.
Test plan
validatejob (specifically the "Run tests" step)🤖 Generated with Claude Code