Open
Conversation
Avoids an error if you don't pass any options object on initialization.
…ways working and sometimes coming back as either 0 or undefined. height() always returns the correct value
… because element get a absolute position every time. I change **absolute** position to **fixed** position, and *tremor* disappeared. It is fix rickharris#7 issue.
Conflicts: jquery.stickyscroll.js
Open
|
@logical-and To be honest, I am not firm with those separate patches and applying changes. Its also hard to track and to get an overview. Questions:
Thanks in advance and for listening. |
Author
|
Hi! Thanks for your questions. I'll try to answer:
;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I merge different forks and apply personal changes. You can see that all in commits messages.
Thanks for the plugin, hope to make it better. ;)