Skip to content

Update library in order to be compliant with recent jQuery version #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlainFolletete wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update library in order to be compliant with recent jQuery version #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
768ea47
Replace .attr('offsetheight') by .height() in order to work with new …
AlainFolletete Feb 22, 2013
86611e5
Update demo files with jQuery 1.9.1 version
AlainFolletete Feb 22, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo-basic.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ <h2>Long sidebar</h2>
<div class="footer">
<p><small>made by Rick Harris <a href="http://orangecoat.com/people/rick">orangecoat.com/people/rick</a>
</div>
<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.5.2/jquery.min.js"></script>
<script src="//ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js"></script>
<script>
$(document).ready(function() {
var el = $('#sidebar-1'),
Expand Down
2 changes: 1 addition & 1 deletion demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ <h2>Long sidebar</h2>
<div class="footer">
<p><small>made by Rick Harris <a href="http://orangecoat.com/people/rick">orangecoat.com/people/rick</a>
</div>
<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script>
<script src="//ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js"></script>
<script src="jquery.stickyscroll.js"></script>
<script>
$(document).ready(function() {
Expand Down
2 changes: 1 addition & 1 deletion fluid-demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ <h2>Long sidebar</h2>
<div class="footer">
<p><small>made by Rick Harris <a href="http://orangecoat.com/people/rick">orangecoat.com/people/rick</a></small></p>
</div>
<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script>
<script src="//ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js"></script>
<script src="jquery.stickyscroll.js"></script>
<script>
$(document).ready(function() {
Expand Down
6 changes: 3 additions & 3 deletions jquery.stickyscroll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@

function bottomBoundary() {
return $(document).height() - settings.container.offset().top
- settings.container.attr('offsetHeight');
- settings.container.height();
}

function topBoundary() {
return settings.container.offset().top
}

function elHeight(el) {
return $(el).attr('offsetHeight');
return $(el).height();
}

// make sure user input is a jQuery object
Expand Down Expand Up @@ -160,4 +160,4 @@
}

};
})(jQuery);
})(jQuery);
2 changes: 1 addition & 1 deletion manual-demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ <h2>Long sidebar</h2>
<div class="footer">
<p><small>made by Rick Harris <a href="http://orangecoat.com/people/rick">orangecoat.com/people/rick</a>
</div>
<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script>
<script src="//ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js"></script>
<script src="jquery.stickyscroll.js"></script>
<script>
$(document).ready(function() {
Expand Down