Feature: Add decimal numbers setting for solve time display by Copilot · Pull Request #108 · ricky9667/HushTimer

Copilot · 2026-02-23T01:15:15Z

Summary

Speedcubers need configurable decimal precision for solve times. This adds a setting to display either 2 or 3 decimal places across all time displays (timer, stats, session history).

Problem: Solve times were hardcoded to 2 decimal places with no way to see finer precision; additionally, switching to 3 decimals showed the 3rd decimal as always 0 due to premature rounding in TimeResult.finalTime
Solution: Add decimal_numbers setting (options: 2 or 3, default: 2) stored as a plain Int and wired through the full settings stack; fix TimeResult.finalTime to preserve millisecond precision by rounding to 3 places instead of 2
Type: [x] Feature [x] Bugfix [x] Refactor [ ] Chore [ ] Docs

Context / Links

Design / spec / ticket:
Related PRs:

Implementation details

decimal_numbers is stored and exposed as a plain Int (no wrapper enum) — simpler to read, write, and extend
The decimal numbers dropdown in SettingsScreen is implemented inline using ListItem + DropdownMenu, showing "2" and "3" as plain text with no string resource translations needed
TimeResult.toString() delegates to the new toFormattedString(numOfDec: Int) method, eliminating duplication and keeping a backward-compatible default of 2
All three display sites (PlayerTimerComponent, StatsComponent, SolveCard) read appSettings.decimalNumbers directly — no hardcoded 2 remains in display paths
Idle/ready timer placeholder adapts dynamically via 0.0.toFormattedString(appSettings.decimalNumbers)
TimeResult.finalTime now uses round(3) instead of round(2) to preserve the millisecond precision already captured by TimerViewModel (inWholeMilliseconds / 1000.0); display rounding is handled by toFormattedString

Screenshots / API changes (if applicable)

UI: Settings screen gains a new "Decimal Numbers" dropdown tile showing 2 and 3 as options. Timer, stats, and session cards reflect the selected precision immediately, including a correct non-zero 3rd decimal when 3 decimals is selected.

Testing

Unit tests
Integration / e2e tests
Manual tests

Steps / commands:

./gradlew :composeApp:check

Manual: toggle between 2 and 3 decimals in Settings and verify timer display, stats panel, and session solve cards all update to the correct precision, with the 3rd decimal showing actual millisecond values (not always 0).

Original prompt

This section details on the original issue you should resolve

<issue_title>Provide decimal settings for solve times</issue_title>
<issue_description># Objective

As a speedcuber user,
I want to have the option to show 2 or 3 decimals after the integer for solve times,
so that I can see more detailed times if i want to.

Implemetation

Domain/Data layer

Settings option name: decimal_numbers, type Int

Options {2, 3}, use 2 as default value.

Presentation layer

Create a SettingsDropdownTile in SettingsScreen that controls the data above

Get decimal_numbers settings in Timer and Session presentation package, currently the times show with Double.toFormattedString(2) in Utils, change the number 2 with the number provided from settings.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Provide decimal settings for solve times #107

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

- Add DECIMAL_NUMBERS key to SettingOptionKeys - Create DecimalNumbers enum with TWO (2) and THREE (3) options - Add decimalNumbers flow and setter to SettingsRepository and SettingsRepositoryImpl - Add decimalNumbers to SettingsState, SettingsAction, SettingsViewModel, LocalSettings - Add string resources for decimal_numbers in EN and ZH - Add SettingsDropdownTile for decimal numbers in SettingsScreen - Add toFormattedString(numOfDec) method to TimeResult - Update PlayerTimerComponent, StatsComponent, SolveCard to use decimalNumbers setting Co-authored-by: ricky9667 <55730003+ricky9667@users.noreply.github.com>

ricky9667 · 2026-02-23T01:52:07Z

@copilot I noticed that when i change to 3 decimals, the 3rd decimal of the time data is always 0. Check TimerEngine and TimerViewModel and see how to make the times count to the 3rd decimal.

Change round(2) to round(3) in TimeResult.finalTime so that millisecond precision is stored when the 3-decimal setting is active. Previously the 3rd decimal was always 0 because finalTime discarded it before toFormattedString was called. Co-authored-by: ricky9667 <55730003+ricky9667@users.noreply.github.com>

Copilot · 2026-02-23T01:54:16Z

@copilot I noticed that when i change to 3 decimals, the 3rd decimal of the time data is always 0. Check TimerEngine and TimerViewModel and see how to make the times count to the 3rd decimal.

The root cause was in TimeResult.finalTime — it applied round(2) to the raw time before any formatting, discarding the 3rd decimal regardless of the display setting. Fixed in ae54b4f by changing round(2) to round(3), preserving millisecond precision. The timer already captures data at millisecond resolution via inWholeMilliseconds / 1000.0; the rounding was just cutting it short too early.

...oseApp/src/commonMain/kotlin/com/rickyhu/hushtimer/settings/domain/options/DecimalNumbers.kt

- Remove DecimalNumbers.kt enum class - Change SettingsRepository, SettingsRepositoryImpl, SettingsState, SettingsAction, LocalSettings to use Int directly - Inline the decimal numbers dropdown in SettingsScreen showing "2"/"3" as plain text (no string resources needed) - Remove decimal_numbers_2/decimal_numbers_3 string resources from EN/ZH - Update all call sites: appSettings.decimalNumbers.value -> appSettings.decimalNumbers Co-authored-by: ricky9667 <55730003+ricky9667@users.noreply.github.com>

Copilot

Pull request overview

This PR adds a configurable decimal precision setting for solve time displays across the HushTimer speedcubing app. The feature allows users to choose between 2 or 3 decimal places, and fixes a bug where the 3rd decimal was always shown as 0 due to premature rounding in the TimeResult calculation.

Changes:

Introduced a new decimal_numbers setting (default: 2, options: 2 or 3) stored as a plain Int throughout the settings stack
Refactored time formatting logic from extension functions to a centralized TimeFormatter utility object with improved rounding precision
Updated all time display components (timer, statistics, session cards) to read and apply the user's decimal preference

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/utils/TimeFormatter.kt	New utility object centralizing time formatting logic with epsilon-corrected rounding
composeApp/src/commonTest/kotlin/com/rickyhu/hushtimer/utils/TimeFormatterTest.kt	Comprehensive test suite for TimeFormatter utility functions
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/core/domain/TimeResult.kt	Changed finalTime rounding from 2 to 3 decimals and added toFormattedString method with configurable precision
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/core/domain/Util.kt	Removed extension functions for time formatting (moved to TimeFormatter)
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/settings/domain/SettingsRepository.kt	Added decimalNumbers flow and setter method
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/settings/domain/SettingOptionKeys.kt	Added DECIMAL_NUMBERS constant
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/settings/data/SettingsRepositoryImpl.kt	Implemented decimalNumbers flow and setter with default value of 2
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/settings/presentation/SettingsState.kt	Added decimalNumbers property
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/settings/presentation/SettingsAction.kt	Added OnSelectDecimalNumbers action
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/settings/presentation/SettingsViewModel.kt	Wired decimalNumbers into settings flow and action handler
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/settings/presentation/LocalSettings.kt	Added decimalNumbers to AppSettingsProvider
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/settings/presentation/SettingsScreen.kt	Added inline dropdown UI for decimal numbers selection
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/timer/presentation/components/PlayerTimerComponent.kt	Updated to use TimeFormatter and appSettings.decimalNumbers
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/timer/presentation/components/StatsComponent.kt	Updated to pass decimalNumbers to time formatting
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/session/presentation/components/SolveCard.kt	Updated to use toFormattedString with appSettings.decimalNumbers
composeApp/src/commonMain/composeResources/values/strings.xml	Added "Decimal Numbers" string resource
composeApp/src/commonMain/composeResources/values-zh/strings.xml	Added Chinese translation for "Decimal Numbers"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-23T03:42:21Z

composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/settings/data/SettingsRepositoryImpl.kt

+        settings.getIntFlow(
+            SettingOptionKeys.DECIMAL_NUMBERS,
+            2,
+        )


Similarly, the decimalNumbers flow should validate that persisted values are within valid bounds (2 or 3). If an invalid value is stored, it should be coerced to the default of 2, similar to how penaltyControlType uses a fallback pattern with fromValue(it) ?: PenaltyControlType.BUTTON.

Suggested change

settings.getIntFlow(

SettingOptionKeys.DECIMAL_NUMBERS,

2,

)

settings

.getIntFlow(

SettingOptionKeys.DECIMAL_NUMBERS,

2,

).map { value ->

if (value == 2 || value == 3) value else 2

}

Copilot · 2026-02-23T03:42:21Z

...seApp/src/commonMain/kotlin/com/rickyhu/hushtimer/settings/presentation/SettingsViewModel.kt

+            is SettingsAction.OnSelectDecimalNumbers -> settingsRepository.setDecimalNumbers(action.decimalNumbers)
        }


The formatting issue on line 62 causes inconsistent indentation. The closing braces should be on separate lines for proper code style consistency with the rest of the file.

composeApp/src/commonTest/kotlin/com/rickyhu/hushtimer/utils/TimeFormatterTest.kt

Copilot · 2026-02-23T03:42:22Z

composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/utils/TimeFormatter.kt

+        var multiplier = 1.0
+        repeat(decimals) { multiplier *= 10 }
+        val shifted = value * multiplier
+        // Add a tiny epsilon in the direction of the value to correct for floating-point
+        // drift where e.g. 1.45 * 10 becomes 14.4999...98 instead of 14.5
+        val epsilon = 1e-10 * if (value < 0) -1 else 1
+        return kotlin.math.round(shifted + epsilon) / multiplier


The round function uses a custom epsilon-based rounding implementation that may not handle all edge cases consistently with standard rounding. Consider documenting or adding tests for edge cases like very small epsilon boundaries (e.g., values very close to the midpoint like 1.4500000000001) to ensure the epsilon approach works correctly across different platforms and doesn't introduce unexpected behavior.

Suggested change

var multiplier = 1.0

repeat(decimals) { multiplier *= 10 }

val shifted = value * multiplier

// Add a tiny epsilon in the direction of the value to correct for floating-point

// drift where e.g. 1.45 * 10 becomes 14.4999...98 instead of 14.5

val epsilon = 1e-10 * if (value < 0) -1 else 1

return kotlin.math.round(shifted + epsilon) / multiplier

val multiplier = 10.0.pow(decimals)

return kotlin.math.round(value * multiplier) / multiplier

Copilot · 2026-02-23T03:42:22Z

composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/settings/data/SettingsRepositoryImpl.kt

+    override fun setDecimalNumbers(value: Int) {
+        settings.putInt(SettingOptionKeys.DECIMAL_NUMBERS, value)
+    }


There's no validation to ensure that decimalNumbers is within valid bounds (2 or 3). If a user manually modifies the persisted settings to an invalid value (e.g., -1, 0, 1, 4, 100), the TimeFormatter methods will still accept and process those values, potentially causing incorrect display formatting. Consider adding validation in setDecimalNumbers to clamp or reject invalid values, or validate the flow in SettingsRepositoryImpl.decimalNumbers to ensure only valid values (2 or 3) are emitted.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

cefb61c

Copilot AI assigned Copilot and ricky9667 Feb 23, 2026

Copilot started work on behalf of ricky9667 February 23, 2026 01:15 View session

Copilot AI changed the title ~~[WIP] Add decimal settings for solve times in user settings~~ feat: Add decimal numbers setting for solve time display Feb 23, 2026

Copilot AI requested a review from ricky9667 February 23, 2026 01:34

Copilot finished work on behalf of ricky9667 February 23, 2026 01:34

Copilot started work on behalf of ricky9667 February 23, 2026 01:52 View session

Copilot finished work on behalf of ricky9667 February 23, 2026 01:54

ricky9667 reviewed Feb 23, 2026

View reviewed changes

...oseApp/src/commonMain/kotlin/com/rickyhu/hushtimer/settings/domain/options/DecimalNumbers.kt Outdated Show resolved Hide resolved

Copilot started work on behalf of ricky9667 February 23, 2026 02:15 View session

Copilot AI requested a review from ricky9667 February 23, 2026 02:20

Copilot finished work on behalf of ricky9667 February 23, 2026 02:20

ricky9667 added 4 commits February 23, 2026 11:30

refactor: 💡 extract time util methods to TimeFormatter

c91ae28

test: 💍 implement TimeFormatter test cases

30016a8

fix: 🐛 fix number rounding errors

50de20c

refactor: 💡 rename and remove default parameter value

1d6dee8

ricky9667 added feature New feature or request test Test case implementation or test integration labels Feb 23, 2026

ricky9667 added this to the Backlog milestone Feb 23, 2026

ricky9667 marked this pull request as ready for review February 23, 2026 03:38

Copilot AI review requested due to automatic review settings February 23, 2026 03:38

Copilot started reviewing on behalf of ricky9667 February 23, 2026 03:39 View session

style: 💄 fix lint

5882e8b

Copilot AI reviewed Feb 23, 2026

View reviewed changes

ricky9667 requested a review from Xanonymous-GitHub February 23, 2026 03:42

test: add test cases for 3 decimals

09e6e3e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ricky9667 changed the title ~~feat: Add decimal numbers setting for solve time display~~ Feature: Add decimal numbers setting for solve time display Feb 23, 2026

ricky9667 merged commit 8e3b556 into master Feb 23, 2026
6 checks passed

ricky9667 deleted the copilot/add-decimal-settings-for-solve-times branch February 23, 2026 05:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature: Add decimal numbers setting for solve time display#108

Feature: Add decimal numbers setting for solve time display#108
ricky9667 merged 10 commits intomasterfrom
copilot/add-decimal-settings-for-solve-times

Copilot AI commented Feb 23, 2026 •

edited

Loading

Uh oh!

ricky9667 commented Feb 23, 2026

Uh oh!

Copilot AI commented Feb 23, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		is SettingsAction.OnSelectDecimalNumbers -> settingsRepository.setDecimalNumbers(action.decimalNumbers)
		}

Uh oh!

Conversation

Copilot AI commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Context / Links

Implementation details

Screenshots / API changes (if applicable)

Testing

Implemetation

Domain/Data layer

Presentation layer

Comments on the Issue (you are @copilot in this section)

Uh oh!

ricky9667 commented Feb 23, 2026

Uh oh!

Copilot AI commented Feb 23, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 23, 2026 •

edited

Loading