Skip to content

Fixes to support parsing of ISO13399 database plib#251

Merged
ytanimura merged 2 commits intoricosjp:masterfrom
zakhenry:feat/fixes-to-support-iso-13399-plib
Mar 19, 2025
Merged

Fixes to support parsing of ISO13399 database plib#251
ytanimura merged 2 commits intoricosjp:masterfrom
zakhenry:feat/fixes-to-support-iso-13399-plib

Conversation

@zakhenry
Copy link

The database can be downloaded from https://dictionary.unm.fr/model/catalogue.html

Only these two small fixes required to successfully parse the file

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zakhenry
Copy link
Author

I'm not sure if something is wrong with the CLA bot as it says I've signed if I go to the site, but the comment above does not update..

@zakhenry
Copy link
Author

@ytanimura i wonder if you can help me resolve this CLA issue? I’d like to get this PR released if possible, thanks!

@ytanimura
Copy link
Contributor

Thank you for your pull request and I am sorry for the delay in responding. I will deal with it next week.
GitHub Actions are not working properly because a PR from external branch cannot read the environment variables. I am also going to update the CHANGELOG, so I will import it as a branch of this repository and make a new pull request.

@ytanimura ytanimura merged commit 90fdc93 into ricosjp:master Mar 19, 2025
10 of 12 checks passed
@zakhenry
Copy link
Author

zakhenry commented Apr 3, 2025

Thanks for merging @ytanimura ! Are you expecting to create a new release for this update too?

@ytanimura
Copy link
Contributor

We will do it at the same time as the release of the new version of truck. It is not that far away, but it will not be today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants