Skip to content

Fixes issue 104 (https://github.com/rid00z/FreshMvvm/issues/104)#105

Open
theberserker wants to merge 2 commits intorid00z:masterfrom
theberserker:104
Open

Fixes issue 104 (https://github.com/rid00z/FreshMvvm/issues/104)#105
theberserker wants to merge 2 commits intorid00z:masterfrom
theberserker:104

Conversation

@theberserker
Copy link
Copy Markdown

Fixes issue 104: RemoveFromNavigation and then popping PageModel causes ReverseInit being called on removed FreshBasePageModel, instead of the one being popped.

…ageModel causes ReverseInit being called on removed FreshBasePageModel, instead of the one being popped
@theberserker
Copy link
Copy Markdown
Author

This is a pull request as discussed here: #104
Please note that there is minor difference in below line, by what we have discussed:
nextPageModel.PreviousPageModel = nextPageModel.PreviousPageModel.PreviousPageModel;
is now:
nextPageModel.PreviousPageModel = nextPageModel.PreviousPageModel?.PreviousPageModel;

I gusess nextPageModel.PreviousPageModel shouldn't ever be null, but I've just added additional null check just to be on safe side.

Also if this is released soon as a NuGet package it would be just awesome :) Do you have any release plan already?

@theberserker
Copy link
Copy Markdown
Author

@rid00z any status progress on that pull request?

@silent-k
Copy link
Copy Markdown

@rid00z Just wondered if this will be rolled out at any point? As it's causing me an issue currently

@joanbarros
Copy link
Copy Markdown

Would be nice to get feedback on this. I'm facing this issue as well.

@Stratosf
Copy link
Copy Markdown

Hello,
I'm facing this issue as well and still have not found a way of fixing it. I am trying to pass parameters so I really need the reverseInit to work properly.. Any suggestions ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants