Adds full test vector runner for all success cases#87
Merged
Conversation
johnnyt
force-pushed
the
76-test-vector-runner
branch
from
6427080 to
72fda68
Compare
Implements comprehensive test vector validation executing 2,861 success test vectors through the complete Client.decrypt_with_keyring flow. Validates all 11 ESDK algorithm suites including both committed suites (0x0478, 0x0578). Test Coverage: - 661 Raw AES tests (128/192/256-bit keys) - 1,100 Raw RSA tests (PKCS1, OAEP-SHA1/256/384/512) - 1,100 Multi-keyring tests (composition scenarios) - Algorithm suite coverage report showing distribution Key Implementation Details: - EDK-based key name extraction for accurate keyring config - Header auth uses full EC with required key filtering - Test vectors run by default when available (+0.8% coverage) - CI integration with test vector caching - Removed deprecation warnings for cleaner output Spec Compliance Fixes: - Header body serialization includes version/type bytes in AAD - Required encryption context properly filtered in header auth - Fixed Dialyzer typespec for compute_header_auth_tag/4 Closes #76
johnnyt
force-pushed
the
76-test-vector-runner
branch
from
72fda68 to
c80274a
Compare
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (77.14%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 92.61% 92.66% +0.04%
==========================================
Files 40 40
Lines 1435 1472 +37
==========================================
+ Hits 1329 1364 +35
- Misses 106 108 +2
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements comprehensive test vector validation executing 2,861 success test vectors through the complete Client.decrypt_with_keyring flow. Validates all 11 ESDK algorithm suites including both committed suites (0x0478, 0x0578).
Test Coverage:
Key Implementation Details:
Spec Compliance Fixes:
Closes #76