Conversation
- Adds type field to Transition struct supporting "internal" | "external" | nil - Updates parser to extract type="internal" attribute from XML transitions - Implements internal transition logic that executes actions without exiting/re-entering source state, per SCXML specification - Fixes initialization to execute onentry actions for all entered states (including ancestors) in proper depth order per W3C spec - Updates feature detector to recognize and mark internal_transitions as supported - Add comprehensive internal transition configuration update logic Internal transitions now correctly: - Executes transition actions without source state exit/entry - Updates configuration from source descendants to target states - Preserves source state (no onexit/onentry execution) - Follows W3C SCXML semantics for internal vs external transitions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Reverts ancestor onentry execution during initialization that was causing event processing order changes breaking 2 regression tests (test403a, test411). Internal transitions work correctly without this initialization change. Maintains full internal transition functionality per W3C SCXML specification while ensuring all 145 regression tests pass. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
johnnyt
force-pushed
the
internal-transitions
branch
from
efdce18 to
2cb9f32
Compare
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
johnnyt
force-pushed
the
internal-transitions
branch
from
a2c2239 to
167a883
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exiting/re-entering source state, per SCXML specification
Internal transitions now correctly: