Fix MPT page issuer text overflow #1277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuan121
changed the title
achowdhry-ripple
previously approved these changes
Jan 8, 2026
Patel-Raj11
previously approved these changes
Jan 8, 2026
kuan121
dismissed stale reviews from Patel-Raj11 and achowdhry-ripple
via
7cc031c
Patel-Raj11
approved these changes
Jan 8, 2026
achowdhry-ripple
approved these changes
Jan 8, 2026
11 tasks
kuan121
added a commit
that referenced
this pull request
Jan 9, 2026
## High Level Overview of Change Fix a bug accidentally introduced in #1277 where the code attempts to capitalize the first character inside the <span>, but that character is (. This PR moves the parenthesis outside of the <span> so the first character of the issuer name is correctly capitalized. <!-- Please include a summary/list of the changes. If too broad, please consider splitting into multiple PRs. --> ### Context of Change <!-- Please include the context of a change. If a bug fix, when was the bug introduced? What was the behavior? If a new feature, why was this architecture chosen? What were the alternatives? If a refactor, how is this better than the previous implementation? If there is a design document for this feature, please link it here. --> ### Type of Change <!-- Please check relevant options, delete irrelevant ones. --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (non-breaking change that only restructures code) - [ ] Tests (You added tests for code that already exists, or your new feature included in this PR) - [ ] Documentation Updates - [ ] Translation Updates - [ ] Release ### Codebase Modernization <!-- In an effort to modernize the codebase, you should convert the files that you work with to React Hooks and TypeScript, and update tests to use the React Testing Library instead of Enzyme. If this is not possible (e.g. it's too many changes, touching too many files, etc.) please explain why here. --> - [ ] Updated files to React Hooks - [ ] Updated files to TypeScript - [ ] Updated tests to React Testing Library ## Before / After See the issuer name section is updated from `RLUSD (ripple)` to `RLUSD (Ripple)` * Before - https://livenet.stg.ripplex.io/token/524C555344000000000000000000000000000000.rMxCKbEDwqr76QuheSUMdEGf4B9xJ8m5De * After - https://livenet.dev.ripplex.io/token/524C555344000000000000000000000000000000.rMxCKbEDwqr76QuheSUMdEGf4B9xJ8m5De <!-- If just refactoring / back-end changes, this can be just an in-English description of the change at a technical level. If a UI change, screenshots should be included. --> ## Test Plan <!-- Please describe the tests that you ran to verify your changes and provide instructions so that others can reproduce. --> <!-- ## Future Tasks For future tasks related to PR. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
Codebase Modernization
Before / After
Before - https://testnet.xrpl.org/mpt/00D3D41E4275D6A8A237BC0AA5268D60986785C36D485705
After - https://testnet.dev.ripplex.io/mpt/00D3D41E4275D6A8A237BC0AA5268D60986785C36D485705
Test Plan