Merged
Conversation
Assets now declare their properties for proper rendering
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Comment on lines
+42
to
48
| .ornament(attachmentAnchor: .scene(.top)) { | ||
| if hasLoadedModel { | ||
| Text(asset.title) | ||
| .font(.title) | ||
| } | ||
| } | ||
| .ornament(attachmentAnchor: .scene(.bottomFront)) { |
There was a problem hiding this comment.
Two .ornament modifiers are now cascaded on the same view. CLAUDE.md prohibits this: "Never cascade multiple .sheet, .alert or similar modifiers — use a single declaration controlled by a Controller."\n\n.ornament is a visionOS presentation/overlay modifier in the same category as .sheet and .alert. Both ornaments should be consolidated into a single declaration controlled by a Controller.\n\nSee:
museum/Museum/Views/AssetDetailView.swift
Lines 41 to 49 in 3840933
Owner
Author
There was a problem hiding this comment.
They have different scene anchors, one is .top and the other is .bottomFront. This is totally fine.
User is now able to be guided through a virtual tour of the asset durring immersion, with detailed descriptions of each scene.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When viewing the asset under immersion, the user is now presented with a floating panel that guides through many predefined spots for a curated experience.