Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains a minor cleanup for the Python code.
I removed unused imports (Added
# NOQAto make linters happy about unused colorama imports, although maybe they can be removed? In any case I do recommend using the more modern rich library if you want pretty colors).There were f-strings that didn't have any placeholders, so I removed the "f".
There were a few lines that ended with a semicolon, and those are removed.
There were a few inconsistencies in keyword argument assignments. I removed the spaces around the
=in those cases to make them consistent.I also have a question: Is Python 2.7 or Python 3.5- support necessary? The
asyncio.coroutinestuff is deprecated, and that should be changed toasync definstead. But if older Python support is required, then that stuff shouldn't change.