Allow using a common custom description#18
Open
tbertels wants to merge 1 commit intoritschwumm:masterfrom
Open
Allow using a common custom description#18tbertels wants to merge 1 commit intoritschwumm:masterfrom
tbertels wants to merge 1 commit intoritschwumm:masterfrom
Conversation
ritschwumm
reviewed
Aug 26, 2018
| }} | ||
| # } else { | ||
| $(upload.description) | ||
| $(upload.description.startsWith("{{Information") ? upload.description : common.description) |
Owner
There was a problem hiding this comment.
i'm not sure this makes sense (or made sense before...) shouldn't we have both descriptions regardless of whether we have an information template or not?
Contributor
Author
There was a problem hiding this comment.
That was to avoid having two {{Information}} template, but allowing both would allow more advanced formatting (e.g. defining the Author in common but Description in upload).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #16