Skip to content

fix: use custom modulemap to prevent Xcode 26 ODR errors with CocoaPods #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mfazekas wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: use custom modulemap to prevent Xcode 26 ODR errors with CocoaPods #428

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1acb28c
fix: use custom modulemap to prevent Xcode 26 ODR errors with CocoaPods
mfazekas Mar 6, 2026
96ebd32
fix: post-process XCFramework to strip RiveRuntime.Swift modulemap su…
mfazekas Mar 11, 2026
9185808
chore: remove unused RiveRuntime.modulemap
mfazekas Mar 11, 2026
3cc72fc
chore: deduplicate comment in build_framework.sh post-process block
mfazekas Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion scripts/build_framework.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ xcodebuild archive \
-destination generic/platform=iOS \
-archivePath ".build/archives/RiveRuntime_iOS" \
SKIP_INSTALL=NO \
BUILD_LIBRARY_FOR_DISTRIBUTION=YES
BUILD_LIBRARY_FOR_DISTRIBUTION=YES

xcodebuild archive \
-configuration ${CONFIGURATION} \
Expand Down Expand Up @@ -123,3 +123,16 @@ xcodebuild \
-framework RiveRuntime.framework \
-output archive/RiveRuntime.xcframework

# Strip the `module RiveRuntime.Swift { ... }` block from every modulemap in the
# XCFramework. The Swift build phase unconditionally appends this block, which
# bakes in C++ interop type definitions for the Swift version used to build the
# XCFramework. Consumers using a different Xcode/Swift version see conflicting
# definitions and get ODR errors. Removing the block prevents Clang from ever
# loading the stale header.
echo "Stripping RiveRuntime.Swift submodule from XCFramework modulemaps..."
find archive/RiveRuntime.xcframework -name "module.modulemap" | while read -r map; do
perl -0777 -i -pe 's/\n*^module RiveRuntime\.Swift \{[^}]*\}\n?//mg' "$map"
echo " Patched: $map"
done
echo "Done."

Loading