Skip to content

style: enhance Swift's API usage and eliminate force casts #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MojtabaHs wants to merge 3 commits into
base: main
Choose a base branch
from
Open

style: enhance Swift's API usage and eliminate force casts #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d2d484
feat: enhance swift api usage and eliminate the force cast to RiveIma…
MojtabaHs Feb 24, 2026
012cd00
feat: enhance swift api usage and eliminate the force cast to RiveFon…
MojtabaHs Feb 24, 2026
446d400
feat: enhance swift api usage and eliminate the force cast to RiveAud…
MojtabaHs Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Example-iOS/Source/Examples/SwiftUI/SwiftOutOfBandAudioAssets.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ struct SwiftOutOfBandAudioAssets: DismissableView {
loadCdn: false,
customLoader: { (asset: RiveFileAsset, data: Data, factory: RiveFactory) -> Bool in

if (asset is RiveAudioAsset){
if let asset = asset as? RiveAudioAsset {
guard let url = (.main as Bundle).url(forResource: asset.uniqueName(), withExtension: asset.fileExtension()) else {
fatalError("Failed to load asset \(asset.uniqueFilename()) from bundle.")
}
Expand All @@ -33,7 +33,7 @@ struct SwiftOutOfBandAudioAssets: DismissableView {
return false
}

(asset as! RiveAudioAsset).audio(decoded)
asset.audio(decoded)
return true;

}
Expand Down
8 changes: 4 additions & 4 deletions Example-iOS/Source/Examples/SwiftUI/SwiftSimpleAssets.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,27 +13,27 @@ struct SwiftSimpleAssets: DismissableView {
var dismiss: () -> Void = {}
@StateObject private var riveViewModel = RiveViewModel(fileName: "simple_assets", autoPlay: false, loadCdn: false, customLoader: { (asset: RiveFileAsset, data: Data, factory: RiveFactory) -> Bool in

if (asset is RiveImageAsset){
if let asset = asset as? RiveImageAsset {

guard let url = (.main as Bundle).url(forResource: asset.uniqueName(), withExtension: "jpeg") else {
fatalError("Failed to locate '\(asset.uniqueName())' in bundle.")
}
guard let data = try? Data(contentsOf: url) else {
fatalError("Failed to load \(url) from bundle.")
}
(asset as! RiveImageAsset).renderImage(
asset.renderImage(
factory.decodeImage(data)
)
return true;
}else if (asset is RiveFontAsset) {
}else if let asset = asset as? RiveFontAsset {
guard let url = (.main as Bundle).url(forResource: asset.uniqueName(), withExtension: asset.fileExtension()) else {
fatalError("Failed to locate '\(asset.uniqueName())' in bundle.")
}
guard let data = try? Data(contentsOf: url) else {
fatalError("Failed to load \(url) from bundle.")
}

(asset as! RiveFontAsset).font(
asset.font(
factory.decodeFont(data)
)
return true;
Expand Down