-
Notifications
You must be signed in to change notification settings - Fork 135
chore(rivetkit): remove deprecated packages #3447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rivetkit): remove deprecated packages #3447
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
ecae19f to
aaf96c9
Compare
8cf9a31 to
7d2f44d
Compare
PR Review: Remove Deprecated PackagesSummaryThis PR removes two deprecated RivetKit packages ( Positive FindingsClean Removal
Appropriate Scope
Issues FoundDocumentation References Not Updated File: Lines 19, 52, 144, 169, 296, 333 contain references to:
Example from line 19: import { type ActorContext, actor } from "@rivetkit/core";Should be: import { type ActorContext, actor } from "rivetkit";File: Line 28 contains an embedded package-lock.json example that may reference old package names (difficult to verify from diff, but worth checking). Recommendations
Code Quality Assessment
VerdictThe code changes are good, but the PR is incomplete due to the documentation references. Once the documentation is updated to use the new package names, this will be ready to merge. The pnpm-lock.yaml changes look like standard dependency resolution updates and don't raise any concerns. |
Merge activity
|
aaf96c9 to
96c15e2
Compare
7d2f44d to
26c9559
Compare
PR Review: Remove Deprecated RivetKit PackagesOverviewThis PR removes the deprecated ✅ Positives
|
Pull Request ReviewSummaryThis PR removes two deprecated placeholder packages (@rivetkit/actor and @rivetkit/core) that have been superseded by the unified rivetkit package. The packages being removed were intentionally designed to throw errors when imported, directing users to migrate to the new package. Code Quality and Best Practices ✅Strengths:
Conventions Followed:
Potential Issues
|

No description provided.