Skip to content

Add songwithamission#248

Open
MaxCoveri wants to merge 10 commits intorjkiv:mainfrom
MaxCoveri:main
Open

Add songwithamission#248
MaxCoveri wants to merge 10 commits intorjkiv:mainfrom
MaxCoveri:main

Conversation

@MaxCoveri
Copy link
Copy Markdown

Fixed errant root note in the last chorus

Copy link
Copy Markdown
Contributor

@jdk13 jdk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bass: Make the slide at measure 55 a little shorter so it doesn't directly connect with the next note on the different string. Measure 87, Could add a slide marker to that final mute sliding up, but dont make it connect with the next note.

Besides at times where we hear a slide, are we sure that every time it goes from F# to C#, it's on the same string? I know I said I heard sliding but I am not sure if it applies to all instances since I only heard it a couple times. Unless this kind of jump is normal or there's live footage. Take that comment with a grain of salt I could be wrong here.

I've realized the problem being you accidentally added all 4 PR Tuning entries into the same pr, instead of doing their own in each PR. You may want to fix that for consistency, as merging one PR means all 4 would make it onto the table despite the other 3 not being in there as well.

Guitar is good

Copy link
Copy Markdown
Contributor

@jdk13 jdk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple final things since it looks like the midi has drastically changed since then, bass fretting looks way better. Measure 55 has a slide connecting to the next note despite jumping strings, should be shortened. The EMH reductions look like they closely resemble CAT/ converting 5 fret to pro EMH, your medium/easy reductions look more suitable if they were hard. Easy should have like 1 note per measure and medium with 2, which isnt that bad to do here cause it's just straight eighth notes.

There's also no bass trainers, this song probably only needs 2, one to cover the chorus riff and one to cover that bridge riff.

guitar is still good

@MaxCoveri
Copy link
Copy Markdown
Author

Measure 55 has a slide connecting to the next note despite jumping strings, should be shortened.

Checked the midi and didn't see any slides, I must have not uploaded changes since then. Updated EMH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants