Remove changed integration test and add unit test for new method#2
Closed
Copilot wants to merge 3 commits intohandle-failed-simulations-in-adaptive-samplingfrom
Closed
Conversation
Wrap the test function to sometimes return np.nan.
…t for _filter_failed_evaluations Co-authored-by: rjoussen <190478390+rjoussen@users.noreply.github.com>
Copilot stopped work on behalf of
rjoussen due to an error
December 1, 2025 10:41
Owner
|
@copilot just write the python files, I will test myself |
Author
The changes are complete in commit a7c1a58. I've removed the |
Copilot
AI
changed the title
[WIP] Remove changed integration test and add unit test for new method
Remove changed integration test and add unit test for new method
Dec 1, 2025
888d627 to
414a3e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context: What and Why?
This PR removes the
DefectivePark91aWrapperfrom the integration testtest_logpdf_gaussian_process.pyand creates a dedicated unit test for the_filter_failed_evaluationsmethod in theAdaptiveSamplingclass.Changes Made
DefectivePark91aWrapperclass anditertoolsimport fromtests/integration_tests/models/test_logpdf_gaussian_process.py, restoring the driver to usepark91a_hifi_on_griddirectlytests/unit_tests/iterators/test_adaptive_sampling.pywith comprehensive tests for_filter_failed_evaluations:test_filter_failed_evaluations_no_failures- Tests when there are no NaN valuestest_filter_failed_evaluations_some_failures- Tests when some evaluations contain NaNtest_filter_failed_evaluations_all_failures- Tests when all evaluations failtest_filter_failed_evaluations_multiple_calls- Tests that failed evaluations accumulate across multiple callsRelated Issues and Pull Requests
_filter_failed_evaluationsmethod inAdaptiveSamplingInterested Parties
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.