feat: Make 5-tap feature opt-in with data-enable-tap-feature attribute#71
Merged
feat: Make 5-tap feature opt-in with data-enable-tap-feature attribute#71
Conversation
This commit implements an opt-in approach for the 5-tap feature in MetaScan: - Added new `data-enable-tap-feature` attribute that must be explicitly set to "true" to enable the tap feature - Modified tap detector to check for the new attribute before activating - Updated MetaScanOptions interface to include enableTapFeature option - Changed tap behavior to only toggle the "M" icon visibility without opening the panel - Added proper state management with stateManager.setEnableDisable() - Created comprehensive test file (tap-feature-test.html) with all test cases - Updated README with documentation for the new opt-in functionality - Maintained backward compatibility with existing features The tap feature now works as follows: - By default, it's disabled unless explicitly enabled - When enabled, 5 taps will toggle the "M" icon visibility - Existing enableOrDisable() API continues to work as before
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements an opt-in approach for the 5-tap feature in MetaScan:
data-enable-tap-featureattribute that must be explicitly set to "true" to enable the tap featureThe tap feature now works as follows: