Conversation
vimcat
Outdated
| if ! version="$(cd "$project_dir" && git describe 2>/dev/null) (git)"; then version=$fallback_version; fi | ||
| if ! version="$(cd "$project_dir" && git describe 2>/dev/null) (git)"; then | ||
| version="$version_tag (checkout)" | ||
| fi |
Collaborator
There was a problem hiding this comment.
We can simplify that:
version="$(cd ...; git foo bar) (git)" || version="$version_tag (chekout)"same for vimpager
Set the latest version tag as version_tag=XXX at the top of vimpager and vimcat. If version assignment fails due to not having .git or a shallow clone, use the version_tag var with the postfix '(checkout)'. On make for the all recipe, update the version_tag var from either git or the ChangeLog files. For make recipes that used `git describe`, write out a XXX-version.txt file instead with the output of `git describe`, or the latest tag from ChangeLog if `git describe` has failed. This allows building from a source tarball (rather than only a git clone.)
rkitover
force-pushed
the
version-tag-top
branch
from
08fd5ba to
7ef32e7
Compare
Owner
Author
|
@lucc updated, thanks! Also, I updated the Makefile to build outside of git. |
Owner
Author
|
@lucc can you please review/merge this and update split-vimcat so that I can finally merge split-vimcat? |
Collaborator
Owner
Author
|
@lucc awesome thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lucc what do you think? I added the Makefile stuff.