Skip to content

Features/improve esys structure#189

Open
MaGering wants to merge 22 commits intodevfrom
features/improve_esys_structure
Open

Features/improve esys structure#189
MaGering wants to merge 22 commits intodevfrom
features/improve_esys_structure

Conversation

@MaGering
Copy link
Collaborator

Fixes #

Before merging into dev-branch, please make sure that the following points are checked:

  • All pre-commit tests passed locally with: pre-commit run -a
  • File CHANGELOG.md was updated
  • The docs were updated
    • if dataset.mds were updated, the dataset docs were regenerated using
      python docs/generate_dataset_mds.py

If packages were modified:

  • File poetry.lock was updated with: poetry lock
  • A new env was successfully set up

WARNING: When modifying use snakemake <=7.32.0, cf. #186

If data flow was adjusted:

  • Data pipeline run finished successfully with: snakemake -jX

  • Esys appdata was created successfully with: snakemake -jX make_esys_appdata

    (with X = desired number of cores, e.g. 1)

@MaGering MaGering added the enhancement ⭐ New feature or request label Aug 31, 2023
@nesnoj
Copy link
Member

nesnoj commented Sep 28, 2023

Notes:

  • Changes are experimental to fix infeasibilities, cf. RC 01.09.23
  • PV fix ad7480a accidentially added here, already cherry-picked from dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ⭐ New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants