Adding Typing // Dataclasses // Python 3.5+ compat #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
thanks for providing this library.
dataclassfor the calibration parameters and removed the obscure attrib dictionary. This is more explicit and safer to use (and avoids a memory leak indictsubclassing). https://peps.python.org/pep-0557/IntEnumfrom std library. https://docs.python.org/3/library/enum.htmlpytzdependency in favor of standarddatetime.timezone. This is a nightmare in python butdatetime.now(timezone.utc)does what is needed here. Now there are no other dependencies thansmbus2👍 . https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow__future__which makes the code safer to use. https://peps.python.org/pep-0585/CamelCaseand prefixed internal functions with single_. Double__is for python internals.Please comment on this MR or request further changes.
Thanks again for this lib, it saved us a lot of time :) I hope this PR will improve the usability of the library