Skip to content

Conversation

@miili
Copy link

@miili miili commented Mar 11, 2022

Hi there,

thanks for providing this library.

Please comment on this MR or request further changes.

Thanks again for this lib, it saved us a lot of time :) I hope this PR will improve the usability of the library

@rm-hull
Copy link
Owner

rm-hull commented Mar 11, 2022

In principle, yes looks good 👍, but I guess my first thought is that will it cause breaking changes? .. if so, is it possible to put a compatibility layer so that folks can still use it unmodified? (I mean this is probably not a huge issue, as we could bump the major version and put a banner up indicating what changed)

@rm-hull
Copy link
Owner

rm-hull commented Mar 11, 2022

@miili
Copy link
Author

miili commented Mar 11, 2022

Yes __future__.annotations is only available from 3.7.

And yes, surely the minor version has to be bump, if not the major. Any production system downstream should fix the dependency version of this library anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants