chore: clean up emmylua diagnostics#502
Merged
cameronr merged 4 commits intormagatti:mainfrom Oct 30, 2025
Merged
Conversation
cameronr
changed the title
Switched to emmylua_ls so cleaning up new diagnostics
cameronr
force-pushed
the
chore/emmylua-cleanup
branch
from
ff4303c to
94fc9e1
Compare
rmagatti
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not urgent at all.
I've started using emmylua_ls as it seems to have better type checking (and lua_ls kept eventually forgetting that
vimas an ok global). These changes are just to clean up the types / add a few nil checks here and there.